Leaflet.DistortableImage icon indicating copy to clipboard operation
Leaflet.DistortableImage copied to clipboard

Update DistortableImage.PopupBar.js

Open Simplecodez opened this issue 2 years ago • 5 comments

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] PR is descriptively titled 📑 and links the original issue above 🔗
  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • [x] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [x] screenshots/GIFs are attached 📎 in case of UI updates
  • [x] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Simplecodez avatar Oct 12 '22 02:10 Simplecodez

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

welcome[bot] avatar Oct 12 '22 02:10 welcome[bot]

gitpod-io[bot] avatar Oct 12 '22 02:10 gitpod-io[bot]

Hi! Can you also link the original issue? Thanks!

anirudhprabhakaran3 avatar Oct 12 '22 03:10 anirudhprabhakaran3

Please how do I do that sir

On Wed, Oct 12, 2022, 04:21 Anirudh Prabhakaran @.***> wrote:

Hi! Can you also link the original issue? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/1126#issuecomment-1275530582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYNHEM3N5J6FUV23VVX73ELWCYVE7ANCNFSM6AAAAAARC3D7YY . You are receiving this because you authored the thread.Message ID: @.***>

Simplecodez avatar Oct 12 '22 03:10 Simplecodez

Hi @Simplecodez, on the description where you have Fixes #0000 edit and replace the zeros with the issue number

cesswairimu avatar Oct 13 '22 17:10 cesswairimu

Hello, from https://github.com/publiclab/Leaflet.DistortableImage/issues/1086 it looks like this was assigned to TaladeogoA, so I'm going to close this. Thank you for your help, I hope we can help you find a new first-timers-only issue instead!

jywarren avatar Oct 18 '22 01:10 jywarren