Leaflet.DistortableImage icon indicating copy to clipboard operation
Leaflet.DistortableImage copied to clipboard

Replace `var` keyword with `let`/`const`

Open TildaDares opened this issue 2 years ago • 56 comments

Hi everyone, we'd like to update this project to use let/const instead of var. This task will be divided into several sub tasks and each one of you will get to work on one file. All you have to do is replace var with let/const where appropriate.

General rules

Use let when you know that the value of a variable will change. Use const for every other variable.

If you'd like to know more about the differences between these keywords, you can read this freecodecamp article on var, let & const

Files to be Updated:

src/components

src/edit

src/edit/actions

src/edit/handles

src/edit/toolbar

src/mapmixins

src/util

src

TildaDares avatar Oct 10 '22 22:10 TildaDares

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help. Please follow the issue template to help us help you 👍🎉😄 If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸 You can make a gif too! Do join our Gitter channel for some brainstorming discussions.

welcome[bot] avatar Oct 10 '22 22:10 welcome[bot]

Hi @TildaDares Thank you for assigning a FTO issue to me I’d like to claim my issue and work on it

leilayesufu avatar Oct 10 '22 22:10 leilayesufu

I will do it

ifeawoyemi avatar Oct 10 '22 22:10 ifeawoyemi

I will take the Task @TildaDares

ifeawoyemi avatar Oct 10 '22 22:10 ifeawoyemi

Hello @TildaDares I claim my task and I’ll work on it! Thank you!✨

Ibom99 avatar Oct 10 '22 22:10 Ibom99

I claim this task @TildaDares

leumasxxx avatar Oct 10 '22 22:10 leumasxxx

Hello @TildaDares I calm this task

mimi-tech avatar Oct 10 '22 22:10 mimi-tech

Hi @TildaDares Thanks! I’ll work on it now.

Thesaleem avatar Oct 10 '22 22:10 Thesaleem

Hi @mimi-tech, your name isn't included in this issue but rest assured we'll find something for you to work on. Thank you!

TildaDares avatar Oct 10 '22 22:10 TildaDares

Hi @TildaDares. Will be working on the task assigned to me. Thanks!

Ranecodes avatar Oct 10 '22 22:10 Ranecodes

hi @TildaDares i would like to let you know i will be working on the issue assigned to me at "https://github.com/publiclab/Leaflet.DistortableImage/blob/main/src/edit/actions/ScaleAction.js"

abd123codes avatar Oct 10 '22 22:10 abd123codes

Hi @TildaDares thank you for this I'm currently working on it

Tammy-Ajoko avatar Oct 10 '22 22:10 Tammy-Ajoko

Thanks @TildaDares , I claim the task and I'm currently working on it

Jennifer-tech avatar Oct 10 '22 22:10 Jennifer-tech

I accept my issue and will work on it @TildaDares

titiodus avatar Oct 10 '22 22:10 titiodus

@TildaDares there a section for screenshot before making the final pull request. I'm not sure on how to link it or can I just go on and make the pull request without it

Tammy-Ajoko avatar Oct 10 '22 22:10 Tammy-Ajoko

HI @TildaDares I claim my issue

OluwatuyiAbiola avatar Oct 10 '22 23:10 OluwatuyiAbiola

Hi @Tammy-Ajoko, you can ignore that. Thank you!

TildaDares avatar Oct 10 '22 23:10 TildaDares

Thanks for this @TildaDares I am working on this

klaus139 avatar Oct 10 '22 23:10 klaus139

Thank you @TildaDares i will work on this

ChiomaNwosisi avatar Oct 10 '22 23:10 ChiomaNwosisi

Thanks @TildaDares I will work on this

RealRichi3 avatar Oct 10 '22 23:10 RealRichi3

HI @TildaDares I claim my issue working on https://github.com/publiclab/Leaflet.DistortableImage/blob/main/src/edit/actions/DeleteAction.js

ijayhub avatar Oct 11 '22 01:10 ijayhub

hi, @TildaDares I just made my first pull request at https://github.com/publiclab/Leaflet.DistortableImage/pull/1099 . id kindly appreciate it if you could get back to me on any other action I may need to take, or i may not have taken as regards the pull request. thank you

abd123codes avatar Oct 11 '22 01:10 abd123codes

THanks @TildaDares I'm working on it

tiffieangel avatar Oct 11 '22 01:10 tiffieangel

Thank you for assigning a FTO issue to me. @TildaDares I’d like to claim my issue and work on it! https://github.com/publiclab/Leaflet.DistortableImage/pull/1103

xiaodaiweiwei avatar Oct 11 '22 01:10 xiaodaiweiwei

Hi @TildaDares I will work on it. Thank you!

chemistry-notfun avatar Oct 11 '22 02:10 chemistry-notfun

Thanks @TildaDares I'm working on it

Lovelyfin00 avatar Oct 11 '22 04:10 Lovelyfin00

Thank you for assigning a FTO issue to me. @TildaDares I’d like to claim my issue and work on it! #1103

I just pull request the fix and I'm not sure whether it's ok. This is the first time for me to submit and I found it's so interesting. I learned a lot from that. I am looking forward to the next contribution!

xiaodaiweiwei avatar Oct 11 '22 04:10 xiaodaiweiwei

Thank you @TildaDares I'll work on the issue assigned to me

sainamercy avatar Oct 11 '22 05:10 sainamercy

Greetings, am I too late to contribute ?

fonkwe avatar Oct 11 '22 07:10 fonkwe

@TildaDares I just made a PR for the issue assigned to me at #1106

Lovelyfin00 avatar Oct 11 '22 08:10 Lovelyfin00