Leaflet.DistortableImage icon indicating copy to clipboard operation
Leaflet.DistortableImage copied to clipboard

Update method creation syntax to ES6 `DragAction.js`

Open first-timers[bot] opened this issue 2 years ago • 14 comments

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • [ ] 🙋 Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • [ ] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • [ ] 📝 Update the file \src/edit/actions/DragAction.js in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.

@@ -1,5 +1,5 @@
 L.DragAction = L.EditAction.extend({
-  initialize: function(map, overlay, options) {
+  initialize(map, overlay, options) {
     options = options || {};
     options.toolbarIcon = {
       svg: true,
@@ -12,7 +12,7 @@ L.DragAction = L.EditAction.extend({
     L.EditAction.prototype.initialize.call(this, map, overlay, options);
   },
 
-  addHooks: function() {
+  addHooks() {
     var edit = this._overlay.editing;
     edit._dragMode();
   },
  • [ ] 💾 Commit your changes

  • [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

first-timers[bot] avatar Oct 02 '22 17:10 first-timers[bot]

Reserved for @Codebat-man for 24 hours

TildaDares avatar Oct 02 '22 20:10 TildaDares

Hello, please I'd like to be assigned to this issue.

fonkwe avatar Oct 08 '22 18:10 fonkwe

Hi @fonkwe, please go ahead. Thank you!

TildaDares avatar Oct 08 '22 18:10 TildaDares

Hi @TildaDares. 👋🏼 If there's an opening, I'd love to take up this issue please!

NPDebs avatar Oct 09 '22 01:10 NPDebs

Hi @NPDebs, please leave a comment in https://github.com/publiclab/plots2/issues/11105 and we’ll look for an issue for you to work on. Thank you!

TildaDares avatar Oct 09 '22 07:10 TildaDares

hi @TildaDares.

Divine-peace avatar Oct 10 '22 04:10 Divine-peace

Pls, I,m new to open source and i need a project to work on

Divine-peace avatar Oct 10 '22 04:10 Divine-peace

Hi @TildaDares. I am new to this community and would really love to contribute. Thanks

Ceejaycodez avatar Oct 11 '22 00:10 Ceejaycodez

Hi @TildaDares. I am a first-timer to this community and would really love to contribute! Thank you!

xiaodaiweiwei avatar Oct 11 '22 05:10 xiaodaiweiwei

Hi @Ceejaycodez, please leave a comment in https://github.com/publiclab/plots2/issues/11105 and we’ll look for an issue for you to work on. Thank you!

TildaDares avatar Oct 11 '22 05:10 TildaDares

Hi @xiaodaiweiwei, you have been an assigned a first-timers-only issue already. You can choose to create issues for others or look for other issues without the first-timers-only label to work on. Thank you!

TildaDares avatar Oct 11 '22 05:10 TildaDares

Ok I got it! Thank you. I have already made a pull request #1103 But I don't know whether there are some errors and have some problems to merge. How could I check for that?

xiaodaiweiwei avatar Oct 11 '22 05:10 xiaodaiweiwei

I'd like to claim this issue 🙋 @TildaDares

Chinazaekpere-Ike avatar Oct 12 '22 17:10 Chinazaekpere-Ike

Hi everyone, a PR has already been opened for this. Thank you!

TildaDares avatar Oct 12 '22 18:10 TildaDares