Leaflet.DistortableImage
Leaflet.DistortableImage copied to clipboard
Update method creation syntax to ES6 `DragAction.js`
🆕🐥☝ First Timers Only.
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
🤔 What you need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
-
[ ] 🙋 Claim this issue: Comment below.
Once claimed we add you as contributor to this repository.
-
[ ] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue
-
[ ] 📝 Update the file \src/edit/actions/DragAction.js in the
Leaflet.DistortableImage
repository (press the little pen Icon) and edit the line as shown below.
@@ -1,5 +1,5 @@
L.DragAction = L.EditAction.extend({
- initialize: function(map, overlay, options) {
+ initialize(map, overlay, options) {
options = options || {};
options.toolbarIcon = {
svg: true,
@@ -12,7 +12,7 @@ L.DragAction = L.EditAction.extend({
L.EditAction.prototype.initialize.call(this, map, overlay, options);
},
- addHooks: function() {
+ addHooks() {
var edit = this._overlay.editing;
edit._dragMode();
},
-
[ ] 💾 Commit your changes
-
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
-
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
- [ ] 🏁 Done Ask in comments for a review :)
🤔❓ Questions
Leave a comment below!
This issue was created by First-Timers-Bot.
Reserved for @Codebat-man for 24 hours
Hello, please I'd like to be assigned to this issue.
Hi @fonkwe, please go ahead. Thank you!
Hi @TildaDares. 👋🏼 If there's an opening, I'd love to take up this issue please!
Hi @NPDebs, please leave a comment in https://github.com/publiclab/plots2/issues/11105 and we’ll look for an issue for you to work on. Thank you!
hi @TildaDares.
Pls, I,m new to open source and i need a project to work on
Hi @TildaDares. I am new to this community and would really love to contribute. Thanks
Hi @TildaDares. I am a first-timer to this community and would really love to contribute! Thank you!
Hi @Ceejaycodez, please leave a comment in https://github.com/publiclab/plots2/issues/11105 and we’ll look for an issue for you to work on. Thank you!
Hi @xiaodaiweiwei, you have been an assigned a first-timers-only
issue already. You can choose to create issues for others or look for other issues without the first-timers-only
label to work on. Thank you!
Ok I got it! Thank you. I have already made a pull request #1103 But I don't know whether there are some errors and have some problems to merge. How could I check for that?
I'd like to claim this issue 🙋 @TildaDares
Hi everyone, a PR has already been opened for this. Thank you!