Some toolbar actions not working when using distortableCollection

[tadiraman]

By default the 'distort' action is enabled and its working. But I am not able to free rotate image.

I can get this working when i am mounting single image by using distortableImageOverlay but not when using multiple images using distortableCollection.

[welcome[bot]]

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

[tadiraman]

Is there someone to help with this? It's been a week. This looks like a bug to me.

[jywarren]

Hello, thanks for reporting this. Do you think it's related to or the same issue as either https://github.com/publiclab/Leaflet.DistortableImage/issues/983 or https://github.com/publiclab/Leaflet.DistortableImage/issues/1007?

We are pushing a fix for those now. Can you help us by also describing how you're using the library? Can you link us to the javascript for where you're using this, or tell us about the projection you're using? A hint in the above linked issues was the use of the L.CRS.Simple projection. Are you using that projection? Thanks!

[tadiraman]

Hi Jeffrey,

Yes, I think it's related to the #983 https://github.com/publiclab/Leaflet.DistortableImage/issues/983 or #1007 https://github.com/publiclab/Leaflet.DistortableImage/issues/1007 issue.

I have a simple javascript code. The toolbar options don't work when using collection.

Here is the code block using collection. Many options in the toolbar don't work. let imgGroup = L.distortableCollection().addTo(map); const img = L.distortableImageOverlay(url); imgGroup.addLayer(img);

But it works when using individual images. const img = L.distortableImageOverlay(url).addTo(map);

Also I am not using any projection. Just kept the default one. I don't see that mentioned anywhere in the docs https://github.com/publiclab/Leaflet.DistortableImage. Let me know if you need any more details. Thanks Raj

On Wed, Sep 28, 2022 at 9:36 PM Jeffrey Warren @.***> wrote:

OK, I've created an issue for it here: #1032 https://github.com/publiclab/Leaflet.DistortableImage/issues/1032 and asked a first-timer to try solving it. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/1027#issuecomment-1261637100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFSGX3C4TKNAUNMBENRTTWATXCHANCNFSM6AAAAAAQNRT43I . You are receiving this because you authored the thread.Message ID: @.***>

--

– Thiyagarajan Adi Raman Associate +1 617 923 7266 sasaki.com http://www.sasaki.com @SasakiDesign https://twitter.com/SasakiDesign Check out our blog http://www.sasaki.com/voices/

[jywarren]

Thank you, is your code shareable so I can see the full context? Even just the html page its running on? It could be related and we can test again once we solve the problem we've identified. But if that doesn't work for your issue we'll need a bit more context to diagnose properly. Thanks!

On Thu, Sep 29, 2022, 10:08 AM tadiraman @.***> wrote:

Hi Jeffrey,

Yes, I think it's related to the #983 https://github.com/publiclab/Leaflet.DistortableImage/issues/983 or #1007 https://github.com/publiclab/Leaflet.DistortableImage/issues/1007 issue.

I have a simple javascript code. The toolbar options don't work when using collection.

Here is the code block using collection. Many options in the toolbar don't work. let imgGroup = L.distortableCollection().addTo(map); const img = L.distortableImageOverlay(url); imgGroup.addLayer(img);

But it works when using individual images. const img = L.distortableImageOverlay(url).addTo(map);

Also I am not using any projection. Just kept the default one. I don't see that mentioned anywhere in the docs https://github.com/publiclab/Leaflet.DistortableImage. Let me know if you need any more details. Thanks Raj

On Wed, Sep 28, 2022 at 9:36 PM Jeffrey Warren @.***> wrote:

OK, I've created an issue for it here: #1032 https://github.com/publiclab/Leaflet.DistortableImage/issues/1032 and asked a first-timer to try solving it. Thanks!

— Reply to this email directly, view it on GitHub < https://github.com/publiclab/Leaflet.DistortableImage/issues/1027#issuecomment-1261637100 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAJFSGX3C4TKNAUNMBENRTTWATXCHANCNFSM6AAAAAAQNRT43I

. You are receiving this because you authored the thread.Message ID: @.***>

--

– Thiyagarajan Adi Raman Associate +1 617 923 7266 sasaki.com http://www.sasaki.com @SasakiDesign https://twitter.com/SasakiDesign Check out our blog http://www.sasaki.com/voices/

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/1027#issuecomment-1262339481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JYYTJ2M6SOFTNEWOXLWAWPGJANCNFSM6AAAAAAQNRT43I . You are receiving this because you commented.Message ID: @.***>

[jywarren]

Hi, @tadiraman can you check if it works after the new v0.21.9 release?