sonora icon indicating copy to clipboard operation
sonora copied to clipboard

Fix trailer encoding

Open bouk opened this issue 2 years ago • 2 comments

I saw trailers encoded like b'grpc-status': b'0' which is happening because strings and bytes were being mixed. Now trailers are always strings and they're encoded in the pack_trailers method

bouk avatar Apr 19 '23 10:04 bouk

Looks good to me, but I don't know about any wider reaching implications of this.

gitpushdashf avatar Apr 19 '23 17:04 gitpushdashf

Thank you very much for the fix.

Any chance you can update the tests to cover this? e.g. unwrap_message_asgi is tested in test_protocol.py

public avatar Apr 21 '23 16:04 public