kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

feat: add stylelint configuration and update package.json for SCSS linting

Open deleonio opened this issue 1 year ago • 1 comments

This pull request introduces Stylelint integration across various packages in the project to enforce CSS and SCSS code quality standards. It also removes the ts-prune dependency and related scripts from the project. Below are the key changes grouped by theme:

Stylelint Integration:

  • Added Stylelint configuration files (.stylelintrc.json) to multiple packages, including components, samples/react, and themes (bwst, default, ecl, and itzbund). These configurations extend stylelint-config-standard and stylelint-config-recommended-scss and include rules for SCSS best practices.
  • Updated lint scripts in package.json files of affected packages to include Stylelint checks for CSS and SCSS files. [1] [2] [3] [4]
  • Added Stylelint dependencies (stylelint, stylelint-config-standard, stylelint-config-recommended-scss, and stylelint-scss) to the package.json files of relevant packages. [1] [2] [3] [4]
  • Updated .stylelintignore in the components package to exclude src/assets/.

Dependency Cleanup:

  • Removed the ts-prune dependency and associated scripts from the root package.json. This includes the removal of the ts-prune script and its invocation in the lint workflow. [1] [2]

Development Environment:

  • Updated .vscode/settings.json to enable Stylelint validation for CSS, SCSS, Sass, and Less files.…ting

Refs: #7537

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • [x] Meaningful pull request title for the release notes
  • [x] Pull request is linked to an issue and all changes relate to the issue
  • [x] Tests to protect this code implemented (if applicable)
  • [x] Manual test performed successfully (if applicable)
  • [x] Documentation or migration has been updated (if applicable)

deleonio avatar Apr 23 '25 17:04 deleonio

Netlify Draft Deployment URL: Logs:

github-actions[bot] avatar Apr 23 '25 17:04 github-actions[bot]