Diskussion: check feature hints

[laske185]

Allgemein über die Logausgaben sprechen. Sind sie sinnvoll? Bieten sie einen Mehrwert?

• [x] Übersicht über die Logausgaben erstellen
• [ ] Grobe Bewertung über die Nützlichkeit

---

some seem to be outdated, while others are just irritating

[chrisalat]

@deleonio hat sich gewünscht dieses Issue gemeinsam im Refinement zu besprechen, deshalb wird erstmal nur eine Log-Liste (ohne Einschätzung) erstellt.

Aktiviert bedeutet, dass wir diesen Log benötigen/behalten, und deaktiviert bedeutet, dass wir es entfernen können.

Debug Logs

• [ ] Log.debug(['Navigator should vibrate ...', navigator.vibrate([100, 75, 100, 75, 100])]) -> Alert component
• [ ] Log.debug('Navigator does not support vibration.') -> Alert component
• [ ] Log.debug(el) -> Search form element start. (searchFormElement function in form controller)
• [ ] Log.debug(el) -> Search form element finished. (searchFormElement function in form controller)
• [ ] Log.debug([KolTabs] The label text for New in { onCreate: { label: string (!), callback: Function }} is not set correctly.);` -> Tab component onCreate

Warning Logs

• [ ] Log.warn([KolModalService] The DOM reference of the modal is not valid.) -> onOpen/onClose of modal component
• [ ] Log.warn('Toaster service is already disposed.', { forceLog: true }) -> dispose-Handler of toaster component
• [ ] Log.warn(_color was empty or invalid (${JSON.stringify(value)}), { forceLog: true }) -> handleColorChange in color.ts

featureHint

• [ ] [KolAccordion] Anfrage nach einer KolAccordionGroup bei dem immer nur ein Accordion geöffnet ist. -> Accordion component
• [ ] [KolAccordion] Tab-Sperre des Inhalts im geschlossenen Zustand. -> Accordion component
• [ ] [KolBadge] Optimierung des _color-Properties (rgba, rgb, hex usw.). -> Badge component
• [ ] [KolTabs] Prüfen, wie man auch einen EventCallback einzeln ändern kann. -> Modal component
• [ ] [KolTabs] Prüfen, wie man auch einen EventCallback einzeln ändern kann. -> Tab component

devWarning

• [ ] The form field raw value is not able to stringify! ${e as string} -> tryToStringifyValue in associated.controller (input-adapter-leanup)
• [ ] [KolNav] Wenn eine horizontale Navigation verwendet wird, kann die Option _hasCompactButton nicht aktiviert werden. -> Nav component
• [ ] In version 3 (v3), horizontal resizing is abolished. The corresponding property is then reduced to the properties "none" (default) and "vertical". -> validateResize in Textarea component

devHint

• [ ] A unique ID on the input fields is not strictly required, but it might be relevant for E2E tests. -> validateId in controller of input component
• [ ] ↓ Search form element start. -> searchFormElement in controller of form component
• [ ] ↑ Search form element finished. -> searchFormElement in controller of form component
• [ ] If you have not focusable or hidden form fields in your form, you should enable noValidate for your form. -> propagateSubmitEventToForm in controller of form component
• [ ] The form field (${this.type}) must have a name attribute to be form-associated. Please define the _name attribute. -> setFormAssociatedValue in associated.controller (input-adapter-leanup)
• [ ] A name on input fields or switches is not strictly required, but it might be relevant for the autocomplete function and for the static submission of the input field. -> validateName in associated.controller (input-adapter-leanup)
• [ ] [KolInputPassword] The 'autocomplete' option should not be set to "on" for a password input field -> validateAutoComplete of input-password component
• [ ] [KolKolibri] You used the complex color schema. For the KoliBri we use need the color as hex string. -> handleColorChange in kolibri component
• [ ] [KolLink] An aria-label must be set when _hide-label is set. -> getRenderValues in link component
• [ ] The abbreviation (${value as string}) used is not defined! -> validateOrg in logo component
• [ ] [KolNav] The navigation structure is not yet validated recursively. -> validateLinks in nav component
• [ ] [KolSelect] Currently, multiple selection is not yet supported. We are working on implementing it to be functional, as there are some gaps in the browser standard. -> validateMultiple in controller of select component (Auskommentiert. Kann das generell entfernt werden?)
• [ ] [KolSelect] For multiple selections, the list length (size) should also be set. -> validateMultiple in controller of select component (Auskommentiert. Kann das generell entfernt werden?)
• [ ] Table: You can not sort the table data, if horizontal and vertical headers are defined at the same time. (https://github.com/public-ui/kolibri/issues/2372) -> validateHeaders in TableStateful component
• [ ] [KolTabs] All tabs are disabled, and therefore no tab can be displayed. -> selectNextNotDisabledTab in Tab component
• [ ] We appreciate any feedback, comments, screenshots, or demo links of an application based on KoliBri ([email protected]). Thank you! -> In a11y.tipps.ts
• [ ] [${component.constructor.name}] The property value: (${value as string}) for '${propName}' is not valid. Allowed values are: ${Array.from(requiredGeneric).join(', ')} -> logWarn in prop.validator.ts
• [ ] Known bug: String array (string[]) -> watchJsonArrayString in prop.validator.ts (Auskommentiert. Kann das generell entfernt werden?)
• [ ] You have used a stringified property value (${oldValue} to ${JSON.stringify(value)}) which type switched from ${typeStr} to ${typeof value}! -> mapString2Unknown in prop.validator.ts

deprecatedHint

• [ ] Date type will be removed in v3. Use 'Iso8601' instead. -> validateValue in input-date component

a11yHint

• [ ] Property hide-error for inputs: Only use when the error message is shown outside of the input component. -> validateHideError in @deprecated/input controller
• [ ] Property hide-label for inputs: Only use for exceptions like search inputs that are clearly identifiable by their context. -> validateHideLabel in @deprecated/input controller
• [ ] [KolBadge] The contrast of ${colorContrast.contrast} (≥7, AAA) is to low, between the color pair ${colorContrast.background} and ${colorContrast.foreground}. -> handleColorChange in color.ts (schema props)
• [ ] The heading or label ("${value}") is not accessible. A label should consist of at least three readable characters. -> getValidationOptions in label.ts (schema props)
• [ ] Property suggestions: Options have accessibility issues in how browsers implemented them and should not be used for now.-> validateSuggestions in suggestions.ts (schema props)
• [ ] A differing Aria-Label (${option.label}) is not accessible. A differing Aria-Label should consist of at least three readable characters. -> validateInputSelectOptions in options.ts (schema props)
• [ ] Don't Use Tabindex Greater than 0: https://adrianroselli.com/2014/11/dont-use-tabindex-greater-than-0.html -> afterPatch in tab-index schema validators

a11yHintDisabled "Disabled" limits accessibility and visibility. From an accessibility perspective, we recommend using the readonly attribute instead of disabled.\n- https://uxdesign.cc/is-it-ok-to-grey-out-disabled-buttons-8afa74a0fae

• [ ] validateDisabled in @deprecated/input controllers
• [ ] validateDisabled in disbaled.ts of schema props

a11yHintLabelingLandmarks Some structural elements, such as the nav tag, can be used multiple times on a webpage. To distinguish between similarly named structural elements, it is necessary to set an ARIA label.\n- https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Navigation_Role#accessibility_concerns

• [ ] validateLabel of breadcrumb component
• [ ] validateLabel of nav component

[deleonio]

Besprechen wir im Refinement nächste Woche Mi.

[github-actions[bot]]

This issue has been automatically marked as stale and will be closed in 10 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, please post a comment or remove the Stale label.

[github-actions[bot]]

This issue was closed because it has been stale for 10 days with no activity. If the issue is still relevant to you, feel free to re-open with a comment.

[github-actions[bot]]

This issue has been automatically marked as stale and will be closed in 10 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, please post a comment or remove the Stale label.

[github-actions[bot]]

This issue was closed because it has been stale for 10 days with no activity. If the issue is still relevant to you, feel free to re-open with a comment.