public_activity icon indicating copy to clipboard operation
public_activity copied to clipboard

Was :fallback accidentally left out?

Open goldstar611 opened this issue 2 years ago • 1 comments

Pull request https://github.com/public-activity/public_activity/pull/148 introduced :fallback but I can't find any branch or gem release with that parameter now. It used to be part of the "2.0" / "unstable" branch but now that 2.0 is released it's definitely gone.

The way the if..else statement in renderable.rb is such that if :display is defined it is always used.

If I sent a PR to re-introduce :fallback would that be acceptable or was :fallback removed intentionally?

Thanks!

goldstar611 avatar Nov 08 '22 13:11 goldstar611

As far as I can tell, this feature never made it into a release. However, the code is still there in the master branch.

$ git br --contains a2e9aa5a7f131ae69c805acb9c445d3685de141b
  master

ur5us avatar Jul 07 '23 01:07 ur5us