public_activity
public_activity copied to clipboard
public-activity
Display more Exception detail.
I can't understand Chinese. Can you try in English instead? @chenqiongqiong
@ur5us I just use e to print the error traceback detail and fix the issue 2 years ago. It's been a while so I can't remember the detail. I would recommend merging it if it's ok. Rejecting it would be fine as well. I just don't want to leave it open forever, ya
@aquadrehz Allow me to rephrase my question: how did it help you to solve your problem? What information does the exception carry that helped you resolve your issue? I’m not completely opposed to merging the PR if it adds valuable detail. However, without further detail it’s hard for me to understand the value add. @chenqiongqiong kindly reviewed your code. While I can’t read (presumably) Mandarin I think what @chenqiongqiong suggested is to extend the same logic to all other exceptions. However, based on our own “wrappers” for these exception types the intention is to reduce noise. Thus, I’m curious how added that helped you? Rails itself will blow up with same exception if it can’t connect to the database.
That time I use the printed warning to check that the DB configuration is incorrect.
If not use this gem the exception would be obvious and failed tom start to app at all.
@aquadrehz Sorry for the late reply. Could you please elaborate on the following:
If not use this gem the exception would be obvious and failed tom start to app at all.
I think this is the important bit but I’m not sure I understand the issue 100% yet. How would the exception be (more) obvious if this gem wasn’t used?
Closing this PR due to lack of further communication and not clearly explaining how this PR solves problems when the database server is not running. Rails will usually handle such errors with enough warnings and errors just fine, so not sure what the problem is.