rxdb icon indicating copy to clipboard operation
rxdb copied to clipboard
verified publisher icon pubkey

Enabled is-my-json-valid unit test

Open linco95 opened this issue 3 years ago • 5 comments

This PR contains:

  • A BUGFIX

Describe the problem you have without this PR

Reenabled unit test for is-my-json-valid as per premium task Depends on PR #193 of is-my-json-valid

Todos

  • [x] Tests
  • [ ] Documentation
  • [ ] Typings
  • [ ] Changelog

linco95 avatar Aug 16 '22 16:08 linco95

The CI is green but https://github.com/mafintosh/is-my-json-valid/pull/193 is not merged. I do not understand why this happens. Can you rebase this PR to the latest master?

pubkey avatar Sep 06 '22 13:09 pubkey

@pubkey I've rebased it to latest master now. I agree, it's weird that the CI is green without the PR being merged 🤔

linco95 avatar Sep 14 '22 19:09 linco95

Still green. This is so strange. is-my-json-valid didn't even have a release.

pubkey avatar Sep 14 '22 21:09 pubkey

Ah I found it, I forgot to throw the error. Fixed in https://github.com/pubkey/rxdb/commit/2fe1cc3fadbdcb2591f0a3786bff3d281e8f0a88 Can you rebase again please? Sorry for hassle.

pubkey avatar Sep 14 '22 21:09 pubkey

@pubkey No worries. Rebase is done 👍🏻

linco95 avatar Sep 15 '22 12:09 linco95

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem.

stale[bot] avatar Mar 26 '23 13:03 stale[bot]

Sorry the stale bot was not meant for PRs.

pubkey avatar Mar 26 '23 14:03 pubkey

Hi @linco95 I am so sorry but I think the is-my-json-valid repo is dead an this will never be merged. I am closing this PR to remove it from my todo list. If it will ever be merged, just ping me an I will reopen.

pubkey avatar Sep 12 '23 22:09 pubkey