Daniel Meyer comments

Results 200 comments of


                                            Daniel Meyer

RxDB does not respond to collection.remove() changes.

No sorry I do not have time for that. Implementing the collection.remove$ observable isn't that hard, so just make a PR if you need that. @phal0r some of these things...

RxDB does not respond to collection.remove() changes.

@Connum ah I forgot. So RxCollection.remove$ already fires on document-delete events. So we should use something like RxCollection.collectionRemoved$ or so.

RxDB does not respond to collection.remove() changes.

@phal0r the replication protocol was constructed in a way that should not leave a broken state no matter when the browser/javascirpt process crashes. After restarting the replication should continue and...

RxDB does not respond to collection.remove() changes.

I think a better approach would be to listen for the internal storage instance of the database. When a collection is removed, its metadata will be deleted. This deletion can...

RxDB does not respond to collection.remove() changes.

The meta docs of the collection should be marked as deleted and therefore you should be able to detect that a collection was removed.

RxDB does not respond to collection.remove() changes.

Should be fixed here: https://github.com/pubkey/rxdb/pull/6013

test: GraphQL query builder functions do not generate output fields for nested queries

Hi @KXLAA This feature is not implemented yet, PR is welcomed.

test: GraphQL query builder functions do not generate output fields for nested queries

Fixed here https://github.com/pubkey/rxdb/pull/5976

fix(datapath) must be equivalent for pull and push

Is this a breaking change?

fix(datapath) must be equivalent for pull and push

Ok that makes it complicated. At the moment there is no major release planned. I added the 16.0.0 label so it will be merged, but this will take a while.