pubgrub icon indicating copy to clipboard operation
pubgrub copied to clipboard

Rename v0.3 Range into BoundedRange

Open mpizenberg opened this issue 3 years ago • 5 comments

I'm currently writing the v0.2 -> v0.3 upgrade guide and realizing we still have the name Range for our default impl of VersionSet. However, this is not exactly the same as the previous v0.2 Range. So to prevent user confusion, and also make the upgrade guide clearer, I'd suggest we rename it to BoundedRange. That's also more precise since it's a range built with inclusive/exclusive bounds.

mpizenberg avatar Oct 22 '22 09:10 mpizenberg

Sounds good!

baszalmstra avatar Oct 22 '22 09:10 baszalmstra

Hi, I would like to work on this issue. Where's the upgrade guide location? Thanks

Michaelin007 avatar Nov 05 '23 13:11 Michaelin007

Hi @Michaelin007 thanks for your interest in this! The upgrade guide currently lives in the pubgrub-rs/guide repo, in a pull request I did not finish. https://github.com/pubgrub-rs/guide/pull/6

You might have to coordinate with @Eh2406 and @charliermarsh who started reading that guide and leaving some comments.

I'm not currently working on the guide so no need to coordinate with me. I'm happy to answer questions though.

mpizenberg avatar Nov 05 '23 13:11 mpizenberg

Hi @mpizenberg noted. Thanks

Michaelin007 avatar Nov 05 '23 13:11 Michaelin007

Let's focus on making the change here. We can deal with updating the guide once the code has been changed.

Eh2406 avatar Nov 06 '23 15:11 Eh2406

With the version-ranges crate split out (#262), the type's main name is now Ranges, which the old Range name being reexported for compatibility.

konstin avatar Oct 30 '24 17:10 konstin