Patrycja

Results 140 comments of Patrycja

> The issue I reported is specific to 1.19 and higher i can reproduce it on 1.18, with lwjgl being linked against glibc being the cause of jvm segfaults >...

after more thorough debugging, it turns out the issue is caused by lwjgl 3.3.1 not falling back to the java implementation, but instead trying to load the native libraries regardless....

This... doesn't really change anything, provided that the module is named `parsify-license` and the function it exports is literally named `isValid`. It's still trivial to locate and patch out.

Turns out current licensing mechanism needs only 6 lines of Python to patch out: ```py with open("app.asar", "rb+") as file: data = file.read() start = data.index(b"const i=async") length = data[start:].index(b";")...

It looks like whatever you're using to load .node files actually uses `process.dlopen` and by analysing the binaries there's one _giant_ string that's present in all of them - `sPrj8fKKYUeHPHtinzxG9WUDLJ3ooV7QNjTEhUdspzdpLdbmJw`....

Just a nitpick, but you might consider building Linux modules as static, so they work on systems that don't use GNU libc.

As for the latest version - it looks better, only thing I could suggest now is certificate pinning.

The only change in the [previous command](https://github.com/parsify-dev/desktop/issues/58#event-6480733104) to patch the license are the auto-generated variable names - the license check mechanism still hasn't changed in 2.0.0-rc3 You can try this...

Honestly, rewriting the library to use EventEmitters and Promises/async functions instead of callbacks would make it so much easier to use, but I don't think Schmavery has interest in anything...

IMO it deserves a rewrite, because currently there's quite a bit of left-over unused/commented code, a few different code styles and it lacks most of newer JS features, like Promises...