react-native-macos icon indicating copy to clipboard operation
react-native-macos copied to clipboard

Published 20 hours ago • verified publisher icon ptmt

Picker component unimplemented

Open eugbash opened this issue 6 years ago • 3 comments

It would be great to have the Picker component on macos that renders the native picker component (https://facebook.github.io/react-native/docs/picker.html). Do you have any plans to implement this?

eugbash avatar Jun 26 '18 11:06 eugbash

Do you mean https://developer.apple.com/documentation/appkit/nscombobox? As far as I know, I tried to implement it before, need to investigate if it's available.

ptmt avatar Jul 03 '18 16:07 ptmt

Exactly. Yes, I found it at /Libraries/Picker/PickerIOS.macos.js I was confused as the render method in /Libraries/Components/Picker/Picker.js returned <UnimplementedView />.

Updating its condition to if (Platform.OS === 'ios' || Platform.OS === 'macos') { // $FlowFixMe found when converting React.createClass to ES6 return <PickerIOS {...this.props}>{this.props.children}</PickerIOS>; } fixed the issue.

However, NSComboBox seems to render not quite right (please, see the image below). nscombobox

eugbash avatar Jul 04 '18 14:07 eugbash

Thanks for your feedback! If you had time to send PR with this (even unfinished) that would be extremely helpful, I'll try to see what's happening with the rendering.

ptmt avatar Jul 07 '18 17:07 ptmt