ptitfred
Review CMake support in magrit client
Could you test this?
It's working in Fedora but I need the Ubuntu mingw details. Have a look at Windows-mingw-i686.cmake, on top. I need the MINGW_PREFIX and Boost_COMPILER. The former is used to name the compiler itself (e.g.: ${MINGW_PREFIX}-g++ or i686-pc-mingw32-g++ in my case) and the latter is added to the library name (e.g.: libboost_program_options${Boost_COMPILER}-1_46_1.dll.a or libboost_program_options-gcc45-1_46_1.dll.a in my case).
The previous two variables should be enough but it may be the case that you had also to supply the CMAKE_FIND_ROOT_PATH in Ubuntu. I'll be happy enough if it builds in my Fedora and your Ubuntu installations.
With regards to maven, I'm just building for Linux. Let's discuss how we do to build all the platforms (the three of them serially? depending on a env. variable? or platform auto-detect?).
(Don't be obliged to merge this! I'm just seeking for your review so far)
I'm pretty sure this doesn't work with maven.
Does the jar produced by mvn client install contains the library + the 2 executables ?
I only tested mvn check (or test? don't remember) in client folder. Can you point me to the error?
sorry, I understood your message it wrongly :-) my question was answered in your comment.
I tested it and it's working (I had just to fix the rpath in c2cf2c0afd9890ad9d24f5db6de15d49fdfcf164).
Nevertheless, the generated zip is weird: it contains both the bash scripts and mine executables. Was it the case before too?
The zipping task is taking bash scripts and then override with yours, resulting a mix of shell scripts and binaries with the should-be-good result.
Sorry to tell that in my Fedora installation, the bash scripts overwrite the native executables :-(
Ok I got it.
The packaging supposes the binaries produced from C++ are put in /client/target/native-binaries. (Remember, the env var I call make with :P).
2012/3/8 daniperez < [email protected]
Sorry to tell that in my Fedora installation, the bash scripts overwrite the native executables :-(
Reply to this email directly or view it on GitHub: https://github.com/ptitfred/magrit/pull/13#issuecomment-4401454
Frdric Menou
I'm honoring that variable and in my system it's writing the binaries in /client/target/native-binaries. Isn't working in yours? where does it put the binaries?