gl4es icon indicating copy to clipboard operation
gl4es copied to clipboard

gl/string_utils.c rename GetLine and CountLines to less generic names

Open kas1e opened this issue 2 years ago • 4 comments

@ptitSeb Hi :)

Some time ago, i did meet with some function/methods clashes of gl4es with the actual game's functions, and lately we port Heretic2 over gl4es, and find out it again.

So question is : can you rename GetLine and CountLines to something not that generic, like maybe GetLine_gl4es and CountLines_gl4es or something ?

Thanks !

ps. i also created pull-request with some small amigaos4 changes in amigaos.c , those ones need it to make gl4es works correctly when used from the .sobjs on amigaos4.

kas1e avatar Jan 05 '23 14:01 kas1e

I can rename to gl4es_getline and gl4es_countlines I guess. Along with all the other string utils functions yes.

ptitSeb avatar Jan 05 '23 15:01 ptitSeb

Done. Is it better now? (oh, you have Heretic2 code, nice :P )

ptitSeb avatar Jan 05 '23 16:01 ptitSeb

Yeah, ti good now, thanks ! As for code : its not me directly have them, its the company which do amigaos4 do have licence for heretic2 for 20 or so years :) They do vesion for old classic amigas with ppc cpu back in times, but now they want to make an os4 version too, so i just help them to betatest / using gl4es / etc.

kas1e avatar Jan 05 '23 17:01 kas1e

Ok. fair enough. Some more classic will come to the amigaos4 then ;)

ptitSeb avatar Jan 05 '23 17:01 ptitSeb