box64 icon indicating copy to clipboard operation
box64 copied to clipboard

Graphic glitches in Warcraft 3 1.26

Open askorbinovaya-kislota opened this issue 1 year ago • 8 comments

bisected the issue to this commit: a5a7d9382ec09c89779ae66f3af2ca2255ea3003

glitches look like this:

Screenshot_2024-03-16-22-29-05-965_com termux x11 Screenshot_2024-03-16-22-29-12-182_com termux x11

and that's how the game menu should look like:

BOX64_DYNAREC=0

Screenshot_2024-03-16-22-30-39-539_com termux x11 Screenshot_2024-03-16-22-30-43-050_com termux x11

simply disabling bigblock (i thought that commit referenced something about it) partially fixes the glitches, but cripples the menu even further:

BOX64_DYNAREC_BIGBLOCK=0

Screenshot_2024-03-16-22-34-45-678_com termux x11 Screenshot_2024-03-16-22-33-33-530_com termux x11

and with the safest dynarec options, the menu is almost fine, with a different glitch affecting the water (x87double fixed the menu):

BOX64_DYNAREC_BIGBLOCK=0 BOX64_DYNAREC_SAFEFLAGS=2 BOX64_DYNAREC_STRONGMEM=2 BOX64_DYNAREC_FASTROUND=0 BOX64_DYNAREC_FASTNAN=0 BOX64_DYNAREC_X87DOUBLE=1

Screenshot_2024-03-16-22-38-54-458_com termux x11

none of those issues appeared on bc770d908af3c310e2e0cd9e1fdc7ca6e0e80fb3 (a5a7d9382ec09c89779ae66f3af2ca2255ea3003 - 1). i've checked the issues, and it seems that no one reported exactly those glitches, but a comment at #1364 states that many games are broken on a version after march 11; the commit after which the issue happened was made on march 10, so i think they had exactly the same problem

i'm testing on android and my cpu is snapdragon 750G

askorbinovaya-kislota avatar Mar 16 '24 20:03 askorbinovaya-kislota

That commit? This is really stronge. I reproduce the inssue on my side, and confirm your result. I'll work on that to see what's wrong (but it maign take time as I'm not home and will have little time this week for box64 dev.)

ptitSeb avatar Mar 16 '24 20:03 ptitSeb

I pushed something, it should be better now, if you can update and test.

ptitSeb avatar Mar 19 '24 01:03 ptitSeb

no glitches on latest commit, works fine now

askorbinovaya-kislota avatar Mar 19 '24 07:03 askorbinovaya-kislota

I pushed something, it should be better now, if you can update and test.

I confirm that there are no more graphical bugs. But there is one significant mistake left? on versions from the beginning of the month everything worked perfectly, the wine prefix loaded in a second, Now if you enable "WINEESYNC=1, WINEESYNC_TERMUX=1" the prefix will load in 30-60 seconds.

Another problem is that the GPU caps viewer refuses to show tests, it simply freezes.

BloodANGELdb avatar Mar 19 '24 13:03 BloodANGELdb

https://github.com/ptitSeb/box64/commit/33846405d8e0af86bb5cfb9dab4ea5026fadb614

This commit actually causes Wine to start up very slowly. It also causes two winedevice.exe instances to appear. After reverting this - everything goes back to normal.

It also caused Mass Effect Andromeda to hang while trying to launch it.

airidosas252 avatar Mar 19 '24 13:03 airidosas252

i also encountered freezes (in warcraft 3) on new version, but i thought it was wine issue...

After reverting this - everything goes back to normal.

i'll try reverting to see if freezes go away

askorbinovaya-kislota avatar Mar 19 '24 14:03 askorbinovaya-kislota

i'll try reverting to see if freezes go away

can confirm, no freezes if i revert that commit

askorbinovaya-kislota avatar Mar 19 '24 23:03 askorbinovaya-kislota

This commit is important. I'll try to check later why it cause some regressions.

ptitSeb avatar Mar 20 '24 00:03 ptitSeb

@askorbinovaya-kislota This should be resolved now. Feel free to re-open this GitHub Issue if you're still encountering issues. Closing as resolved.

LukeShortCloud avatar Oct 31 '24 22:10 LukeShortCloud