panel icon indicating copy to clipboard operation
panel copied to clipboard

Fixed 'Subuser without all permissions cannot edit another Subuser's permissions' and 'PermissionTitleRow Select All applies to disabled/dis-allowed permissions'

Open MackenzieMolloy opened this issue 1 year ago • 0 comments

Currently, Subusers who don't have all permissions for a server cannot edit another Subuser's permissions due to the SubuserRequest not accounting for pre-existing permissions, so the Panel believes the user is trying to edit all the permissions.

This is the error the user gets when their request is denied. image

So, I've added some logic to work out which permissions were removed and added and then check the user has all those modified permissions.

In relation to this, Subusers can currently use the Select All even when all permissions within the group are disabled causing all disabled/dis-allowed permissions to be selected - I've fixed this bug in this PR. image

With my fix, the button is disabled when all permissions within the group are disabled and when there are some (not all) permissions available, only the ones available are affected.

MackenzieMolloy avatar Aug 06 '24 23:08 MackenzieMolloy