panel icon indicating copy to clipboard operation
panel copied to clipboard

Don't display the port of a server if the allocation alias is set.

Open LaserKaspar opened this issue 1 year ago • 8 comments

Is there an existing feature request for this?

  • [X] I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

image to image

Describe the solution you'd like.

Either a permanent change, an option in .env of the panel, or some other config.

Additional context to this request.

Simple modification to ServerDetailsBlock.tsx#L66 I have on my instance. I don't know if this feature is in the interest of the general public, but I think it makes "normal" users of the panel less confused (we use aliases to assign them subdomains).

Anyways, great panel!

LaserKaspar avatar Dec 25 '23 16:12 LaserKaspar

You can not allocate port 80? Or any port lower then 1024?

The alias is just there to show a domain. So that for game servers you can connect to domain:port instad of needing to remember the ip.

QuintenQVD0 avatar Dec 25 '23 16:12 QuintenQVD0

That's irrelevant to the issue. Some tools/services/etc. require the port to be specified in cases that the domain (or alias in this case) is ambiguous. Removing it could lead to many different issues, and to be honest there isn't really a reason to do so other than visual aesthetics.

devnote-dev avatar Dec 25 '23 16:12 devnote-dev

Ok, then I'll just keep it for my instance. The only reason for it is aesthetics and it's easier to copy/paste the thing you want. But as aliases are assigned per allocation, maybe a toggle option to hide a port on a specified allocation wouldn't break stuff for people that don't want it and the ones who do, can easily enable it?

The alias is just there to show a domain. So that for game servers you can connect to domain:port instad of needing to remember the ip.

Exactly, some game servers allow to specify a port via a srv record so you don't even have to remember the port.

LaserKaspar avatar Dec 25 '23 16:12 LaserKaspar

Imo this should be toggleable per server, some servers might just use an A record instead of SRV for example

Jcodeerd avatar Dec 25 '23 16:12 Jcodeerd

Maybe on a per egg basis? But per Server would also be great.

LaserKaspar avatar Dec 25 '23 19:12 LaserKaspar

I would say to have this per egg AND based on if the alias is set:

✅ - Alias ❌ - Feature enabled ❌ - Port still shows

❌ - Alias ✅ - Feature enabled ❌ - Port still shows

✅ - Alias ✅ - Feature enabled ✅ - Port is hidden.

Codixer avatar Dec 26 '23 23:12 Codixer

Another possibility would be introducing a new kind of alias (maybe per Server) that just completely overwrites the Address field for the user.

LaserKaspar avatar Dec 27 '23 10:12 LaserKaspar