panel icon indicating copy to clipboard operation
panel copied to clipboard

feat(admin): settings ui

Open alexevladgabriel opened this issue 2 years ago • 14 comments

First task done:

  • [x] Fixing route handler for admin settings

Backend

Settings

  • [x] Created base controller, added default json response with data
  • [x] Make transformer to normalize the API response

Frontend

General Settings

  • [x] Submit handler
  • [x] Add default fields from v1.0
  • [x] Populate fields with data

Security Settings

  • [x] Submit handler
  • [x] Add default fields from v1.0
  • [x] Populate fields with data

Advanced Settings

  • [ ] Submit handler
  • [x] Add default fields from v1.0
  • [x] Populate fields with data

alexevladgabriel avatar Sep 21 '23 06:09 alexevladgabriel

image image

alexevladgabriel avatar Sep 21 '23 08:09 alexevladgabriel

I've didn't see your PR #4733 @omametech. I'm glad to see people like you willing to help.

alexevladgabriel avatar Sep 21 '23 08:09 alexevladgabriel

Require to make transformer to normalize API format. Look into it tomorrow.

image

alexevladgabriel avatar Sep 21 '23 09:09 alexevladgabriel

@alexevladgabriel Google analytics are not present anymore in the latest panel release

See:

  • https://github.com/pterodactyl/panel/pull/3912
  • https://github.com/pterodactyl/panel/blob/1.0-develop/database/migrations/2022_01_25_030847_drop_google_analytics.php

QuintenQVD0 avatar Sep 21 '23 11:09 QuintenQVD0

@alexevladgabriel Google analytics are not present anymore in the latest panel release

See:

* [ref: remove google analytics #3912](https://github.com/pterodactyl/panel/pull/3912)

* https://github.com/pterodactyl/panel/blob/1.0-develop/database/migrations/2022_01_25_030847_drop_google_analytics.php

Google Analytics was not added by me, it was already existent setting in the v2. I would love to integrate other solutions for analytics, more focussed on privacy.

  • Plausible
  • Fathom

I will indeed remove it from UI.

alexevladgabriel avatar Sep 21 '23 14:09 alexevladgabriel

image

alexevladgabriel avatar Sep 22 '23 07:09 alexevladgabriel

Require to find a better method for data passing between main component & childrens, maybe useContext or store.

alexevladgabriel avatar Sep 22 '23 14:09 alexevladgabriel

Remained to handle the updates with backend.

alexevladgabriel avatar Sep 28 '23 07:09 alexevladgabriel

I feel like the settings UI with all of the boxes gets really cluttered and convoluted, I could PR something off this to try and clean it up. Glad to see some work in public pterodactyl, it's been a long time.

camden-git avatar Oct 01 '23 00:10 camden-git

Playing with the design right now and I feel like having 5 (4 real) pages doesn't make sense. The general page has 2 settings and one of which does nothing. Maybe move everything but mail into one tab? We could do sections to separate the forms, something like this. image

camden-git avatar Oct 03 '23 01:10 camden-git

@alexevladgabriel What do you think about the changes I said above?

camden-git avatar Oct 03 '23 17:10 camden-git

@alexevladgabriel What do you think about the changes I said above?

I've looked into more designs from multiple sources & real apps usage. My only issue with the current design would be that there are to many box in boxes. I like the separation of the settings based on tabs (pages). At this moment there isn't enough content, to fill the pages and can be "really cluttered and convoluted" how you said. I will look more on design ideas, sketches in remaining time and attach here some screenshots.

alexevladgabriel avatar Oct 03 '23 19:10 alexevladgabriel

@alexevladgabriel What do you think about the changes I said above?

I've looked into more designs from multiple sources & real apps usage. My only issue with the current design would be that there are to many box in boxes. I like the separation of the settings based on tabs (pages). At this moment there isn't enough content, to fill the pages and can be "really cluttered and convoluted" how you said. I will look more on design ideas, sketches in remaining time and attach here some screenshots.

In terms of this PR, worry about functionality. Before any of the v2 changes get properly released there will be multiple polish passes on the UI.

matthewpi avatar Oct 03 '23 19:10 matthewpi

Short preview:

https://www.loom.com/share/263e55a3217a4df1b6b45ab2a75e4346?sid=616d1ce1-81f9-421e-b7c8-30674bca0ad2

alexevladgabriel avatar Dec 22 '23 17:12 alexevladgabriel