panel icon indicating copy to clipboard operation
panel copied to clipboard

Panel upgrade won't delete old version files

Open UndercoverNL opened this issue 1 year ago • 1 comments

Current Behavior

When upgrading the panel from 1.8.2 to 1.9+ the files deleted in 1.9 won't be deleted for the user updating the panel (all console files in the root resources directory and the SetupTwoFactorModal file. Which isn't harmless when having 0 modifications to your panel as you pull the builded version, but when users want to make changes to their panel. E.G building, it will give tons of errors due to those undeleted files.

I know that the priority of Pterodactyl isn't by users modifying their panel but over 75% of the users have at least some kind of modification needing to build for that.

Now all developers like me need to tell their clients to delete all files their selves to build, as this isn't included in the upgrading process.

And in general it is just messy to keep files in the project which aren't in use anymore.

Expected Behavior

Having all removed files deleted when upgrading from any version (but 1.8 > 1.9 a specially).

Steps to Reproduce

Upgrade your panel from < 1.8.2 to > 1.9

NOT FRESH INSTALL

Panel Version

1.9>

Wings Version

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • [x] I have searched the existing issues before opening this issue.
  • [X] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • [X] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

UndercoverNL avatar Jul 10 '22 16:07 UndercoverNL

Will be fixed in #4212 if merged.

devnote-dev avatar Jul 10 '22 16:07 devnote-dev