panel
panel copied to clipboard
fix: update upgrade command
This PR fixes issues present in v1.8.x
and v1.9.x
with upgrading the panel frontend files, as well as implements a backup system for the current version that users can rollback to if upgrading fails.
Edit: closes #4251
What if the user's pterodactyl installation isn't at /var/www/pterodactyl
?
What if the user's pterodactyl installation isn't at
/var/www/pterodactyl
?
As far as I'm aware the original version didn't make exceptions for this, I don't see why it should now.
See previous attempts: #4103, #3934
See previous attempts: #4103, #3934
The first PR you mentioned was more or less an entirely new command that wasn't backwards compatible (i.e. not usable until the next major version), and I'm going to disregard the second one for obvious reasons. Furthermore, unlike those attempts, this PR resolves the existing issues rather than providing alternatives.
I spoke to Dane about this already and I'm aware that this PR may be closed in favor of the bash script being proposed by the core team, but said script is not available yet and I was still given the go-ahead to do this.
As far as I'm aware the original version didn't make exceptions for this, I don't see why it should now.
i mean the original upgrade use the current directory not? for my case i use a custom directory for the app and the command work with no issues (ignorin when broken a few updates ago) maybe is better ask for the install directory or detect where work?
i mean the original upgrade use the current directory not? for my case i use a custom directory for the app and the command work with no issues (ignorin when broken a few updates ago) maybe is better ask for the install directory or detect where work?
It could probably be implemented as a flag option, but:
- I don't know if that's something that would be agreed on by the core team
- that would also mean having to implement extra steps in the rollback system for people not using
/var/www/
i mean the original upgrade use the current directory not? for my case i use a custom directory for the app and the command work with no issues (ignorin when broken a few updates ago) maybe is better ask for the install directory or detect where work?
It could probably be implemented as a flag option, but:
- I don't know if that's something that would be agreed on by the core team
- that would also mean having to implement extra steps in the rollback system for people not using
/var/www/
maybe a flag can be good like another things.. or make the .env can set this value for another things?
maybe a flag can be good like another things.. or make the .env can set this value for another things?
I've added this as a flag option now.
Closing as this wont be merged into v1.x.