panel icon indicating copy to clipboard operation
panel copied to clipboard

fix: update upgrade command

Open devnote-dev opened this issue 2 years ago • 8 comments

This PR fixes issues present in v1.8.x and v1.9.x with upgrading the panel frontend files, as well as implements a backup system for the current version that users can rollback to if upgrading fails.

Edit: closes #4251

devnote-dev avatar Jun 29 '22 20:06 devnote-dev

What if the user's pterodactyl installation isn't at /var/www/pterodactyl?

hwalker928 avatar Jun 29 '22 20:06 hwalker928

What if the user's pterodactyl installation isn't at /var/www/pterodactyl?

As far as I'm aware the original version didn't make exceptions for this, I don't see why it should now.

devnote-dev avatar Jun 29 '22 20:06 devnote-dev

See previous attempts: #4103, #3934

FoksVHox avatar Jun 29 '22 21:06 FoksVHox

See previous attempts: #4103, #3934

The first PR you mentioned was more or less an entirely new command that wasn't backwards compatible (i.e. not usable until the next major version), and I'm going to disregard the second one for obvious reasons. Furthermore, unlike those attempts, this PR resolves the existing issues rather than providing alternatives.

I spoke to Dane about this already and I'm aware that this PR may be closed in favor of the bash script being proposed by the core team, but said script is not available yet and I was still given the go-ahead to do this.

devnote-dev avatar Jun 29 '22 21:06 devnote-dev

As far as I'm aware the original version didn't make exceptions for this, I don't see why it should now.

i mean the original upgrade use the current directory not? for my case i use a custom directory for the app and the command work with no issues (ignorin when broken a few updates ago) maybe is better ask for the install directory or detect where work?

Doc94 avatar Jun 30 '22 03:06 Doc94

i mean the original upgrade use the current directory not? for my case i use a custom directory for the app and the command work with no issues (ignorin when broken a few updates ago) maybe is better ask for the install directory or detect where work?

It could probably be implemented as a flag option, but:

  1. I don't know if that's something that would be agreed on by the core team
  2. that would also mean having to implement extra steps in the rollback system for people not using /var/www/

devnote-dev avatar Jun 30 '22 22:06 devnote-dev

i mean the original upgrade use the current directory not? for my case i use a custom directory for the app and the command work with no issues (ignorin when broken a few updates ago) maybe is better ask for the install directory or detect where work?

It could probably be implemented as a flag option, but:

  1. I don't know if that's something that would be agreed on by the core team
  2. that would also mean having to implement extra steps in the rollback system for people not using /var/www/

maybe a flag can be good like another things.. or make the .env can set this value for another things?

Doc94 avatar Jul 01 '22 00:07 Doc94

maybe a flag can be good like another things.. or make the .env can set this value for another things?

I've added this as a flag option now.

devnote-dev avatar Jul 09 '22 00:07 devnote-dev

Closing as this wont be merged into v1.x.

devnote-dev avatar Jan 16 '23 18:01 devnote-dev