panel icon indicating copy to clipboard operation
panel copied to clipboard

Eggs' docker images get automatically sorted

Open YusufYaser opened this issue 3 years ago • 12 comments

Current Behavior

I set my docker images in an egg to this for example

Java 17|java-17:latest
Java 16|java-16:latest
Java 11|java-11:latest
Java 8|java-8:latest

Once I save the egg, it gets automatically sorted to this

Java 8|java-8:latest
Java 11|java-11:latest
Java 16|java-16:latest
Java 17|java-17:latest

It is not a huge deal, but it is a bit annoying.

Expected Behavior

Docker images should not be automatically sorted by the panel as there is no reason to do that, the user can, just like how it acted before version 1.8.0 of the panel.

Steps to Reproduce

Create an egg and put this in the docker images

Java 17|java-17:latest
Java 16|java-16:latest
Java 11|java-11:latest
Java 8|java-8:latest

Something like this could work too

something:latest
image:latest
abc:latest
test:latest

After you apply the changes, they will get automatically sorted.

Panel Version

1.8.1

Wings Version

1.6.3

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • [x] I have searched the existing issues before opening this issue.
  • [X] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • [X] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

YusufYaser avatar May 31 '22 12:05 YusufYaser

That is numerical order 8 being the lowest and 17 being the highest. I don't see an issue here as most people probably expect them to be in that order.

parkervcp avatar May 31 '22 12:05 parkervcp

That is numerical order 8 being the lowest and 17 being the highest. I don't see an issue here as most people probably expect them to be in that order.

I see that it's better to let the user order them the way they like

YusufYaser avatar May 31 '22 13:05 YusufYaser

I can't reproduce that. For me the images stay in the order I entered them.

Boy132 avatar Jun 01 '22 21:06 Boy132

I can't reproduce that. For me the images stay in the order I entered them.

What images did you test? Did you try the one I put in the issue? Which panel version are you using? I’ve tested it on two different panel installations

YusufYaser avatar Jun 01 '22 21:06 YusufYaser

I can't reproduce that. For me the images stay in the order I entered them.

What images did you test? Did you try the one I put in the issue? I’ve tested it on two different panel installations

I used the examples you provided:

Java 17|java-17:latest
Java 16|java-16:latest
Java 11|java-11:latest
Java 8|java-8:latest

And they stayed in this order.

Boy132 avatar Jun 01 '22 21:06 Boy132

I can't reproduce that. For me the images stay in the order I entered them.

What images did you test? Did you try the one I put in the issue? I’ve tested it on two different panel installations

I used the examples you provided:

Java 17|java-17:latest
Java 16|java-16:latest
Java 11|java-11:latest
Java 8|java-8:latest

And they stayed in this order.

How about the panel version? Just tested it again on 1.8.1 now and it still automatically get sorted

YusufYaser avatar Jun 01 '22 21:06 YusufYaser

I’m using the default panel too, I did not modify its code.

YusufYaser avatar Jun 01 '22 21:06 YusufYaser

How about the panel version? Just tested it again on 1.8.1 now and it still automatically get sorted

I'm also on 1.8.1, no modifications.

Boy132 avatar Jun 01 '22 21:06 Boy132

Part of this may be your browser organizing the list.

parkervcp avatar Jun 02 '22 00:06 parkervcp

Part of this may be your browser organizing the list.

Thought about that too. I tested with Opera GX, Firefox and Edge and can't reproduce it with any of these three.

Boy132 avatar Jun 02 '22 06:06 Boy132

Part of this may be your browser organizing the list.

I use the new Microsoft Edge (Chromium)

YusufYaser avatar Jun 02 '22 07:06 YusufYaser

Tried it also on my phone on Safari, it still sorts

YusufYaser avatar Jun 02 '22 07:06 YusufYaser

This is because the images are stored as a JSON object, not text. This may be addressed if we change the way eggs are stored and imported/exported, but I don't see why we should go out of our way to solve what some people would consider a feature.

matthewpi avatar Nov 02 '22 18:11 matthewpi