Popup Console

[mrxbox98]

This commit adds a popup console. Currently the console opens in a new tab, but I can make it a new window if needed. The code also might have a lot of unnecessary checks as I was testing it for a while. This has been tested on desktop and works. This closes https://github.com/pterodactyl/panel/issues/2584

Preview:

[Rezanans-wow]

Nice

[camw0]

A nice addition would be to make the button change depending on whether the console is in fullscreen mode or not. For example, if the console is fullscreen, the button should change to an X or an arrow which links to the main console page for easy navigation. (Also, side note, this needs to be eslinted)

[dtrasca]

any comment on how to use this ? I changed the 3 files (Console, ServerConsole and ServerRouter) and restarted nginx, but Im not good at it as you can see. Any help ? x

[mrxbox98]

any comment on how to use this ? I changed the 3 files (Console, ServerConsole and ServerRouter) and restarted nginx, but Im not good at it as you can see. Any help ? x

I suggest waiting until this is merged, but if you apply the patch file you can run yarn build:production to use it.

[mrxbox98]

Failing check irrelevant to this commit.

[camw0]

Having the console pop-out in a new window might be the best approach. It would be cleaner while also making it an isolated window instead of another 'page'.

[mrxbox98]

Having the console pop-out in a new window might be the best approach. It would be cleaner while also making it an isolated window instead of another 'page'.

https://github.com/pterodactyl/panel/pull/3904/commits/f3a402445e3cbb499f3728d8248552ce808ecb41 should do this

[anondev-sudo]

This is really good I think, maybe remove the enter command field too and make that it will display cursor and that every key will be forwarded there. It can solve https://github.com/pterodactyl/panel/issues/3712

For example in xterm.js demo, when you press CTRL + C key it is sent there. https://xtermjs.org/ On pterodactyl console you can't do this. I think that type a command field should be removed and rather use normal cursor and forward keys to concols when you have clicked with mouse on the console.

[mrxbox98]

I havent worked on this pr in a while, here is better version from VinGal0

[mrxbox98]

Accidentally closed this one too not sure what git and github are doing but apparently this is the only way for me to update my PRs

[mrxbox98]

There may be some unintended side effects with this PR since I spent an hour trying to fix git