psychedelicious

Results 379 comments of psychedelicious
trafficstars

I don't support this change (or any change related to the "missing models" edge case). We should never end up with models missing unless the user sticks their fingers in...

marking draft pending more discussion, good points raised

> In the new test case, I don't understand why this config is expected to fail: This should fail bc 4.0.1 isn't a valid registered config schema version

> It looks like there used to be schema validation tests in the Graph class, but I don't see them in there any longer, so I removed the Graph assertions...

> I'm still not following; maybe it's too late at night. The current schema version in main (and this PR) is 4.0.1 and there are two migrators defined, one from...

> I looked at the Graph class and I don't see where the test for denied nodes is occurring. The only place where I can find app_config.deny_nodes is in BaseInvocation.get_invocations(),...

Ok, I've revisited this PR and made some changes, simplified a few things and made the tests more rigorous. I'm not entirely convinced the extra complexity in this change is...

I noticed in #2106 the maintainer says: > The `.deepPartial` API has this same problem. I'm deprecating it for the same reason. However, that issue is about 9 months old...

On zod 3.22.4, this patch breaks a ton of types.

> Could you provide some example types so I can modify the PR accordingly? > > Those examples could be added as type level regression tests. Sure. The issues are...