gradle-execfork-plugin icon indicating copy to clipboard operation
gradle-execfork-plugin copied to clipboard

Published 20 hours ago • verified publisher icon psxpaul

Fix logging behaviour

Open hesch opened this issue 4 years ago • 2 comments

I encountered a bug where the output of the process was not shown on Windows in IntelliJ. The reason for this bug was, that the process is logging lines CRLF line endings. I changed the behaviour of the OutputStreamLogger-Class to handle CRLF, LF and CR line endings.

hesch avatar Jun 05 '20 12:06 hesch

@psxpaul Did you have a chance to review this PR? I would love to have this bug fixed in my Gradle build.

hesch avatar Jun 10 '20 10:06 hesch

Hi @hesch sorry for the long delay. I don't have a windows machine, so I can't duplicate the bug you're seeing in IntelliJ. I did have some concerns around this approach. The unit test implies that any ending \r character would get swallowed. And on Unix machines I wonder if this would replace all \r\n with just \n. That might be desirable for some people, but not others.

psxpaul avatar Apr 13 '21 17:04 psxpaul