Prasanna Swaminathan

Results 23 comments of Prasanna Swaminathan

@sgowroji whoops, I made the repository private by accident. I've made it public now so those links should work!

Hmm, interesting, I'm not able to reproduce it now either. Maybe something was cached? Interestingly, one of our other team members was experiencing this as well. I'll ask him to...

@cgruber where does this stand? We would really like to see this in motion and I'm very willing to help if there are things I can do.

I don't have a solution here, but digging into this more, this does appear to be resolved from the rules_kotlin side, and instead this stems from the annotation processor itself....

@Bencodes @oliviernotteghem this does not fully address the regression introduced in 1.9 for us. We have `kt_android_library` rules that use other attributes, specifically `proguard_specs`, that are not getting passed in...

@oliviernotteghem thanks for responding! > are you sure proguard_specs are needed by the inner sandwich android lib? These should be set on the outer lib, no? I'm not sure. I...

@oliviernotteghem thinking about this a little more: Looking at the list of `android_library` attributes, the only ones that aren't handled at the moment by either the outer or inner library...

~~I have something that might work in pswaminathan/rules_spm#1. I've PRed it on my repo because its base is my other PR.~~ Edit: Just PRed as #146

Thanks @ted-xie ! That does indeed get me farther, but still a failure: ``` bazel build --verbose_failures java/com/basicapp:basic_app Starting local Bazel server and connecting to it... INFO: Analyzed target //java/com/basicapp:basic_app...

Whoops, turns out I do have some local customizations that I had forgotten about. I'll revert back to `main` and try again.