Peter Štibraný
Peter Štibraný
What is the status of this PR? It seems like in the current state it was good-enough to be merged. Is there anything we can do to help?
Is this related? https://github.com/grafana/mimir/pull/552
We can also make cleaner more fair by randomizing order of users each time.
> I am not 100% sure I understand what you mean. I will try to rephrase: when you call this worker pool for a user and that already has an...
> Yes, that is exactly what I meant. The point is that `f` may carry a state, and subsequent invocations may pass `f` with updated state. By using `f` from...
> mimirtool will be documented in #2481. @pstibrany is anything else left to document after #2481 will be merged? Not at the moment. Once we add validation and (hopefully/possibly) index...
Please make sure to do any merge of release branch to `main` using Merge commit, not by using Squashing.
Obsoleted by https://github.com/grafana/mimir/pull/2833. > Could you rebase again, please? :| We can't rebase release branches. We could merge `main` to release-2.3 to fix conflicts, but that pulls all changes from...
What if distributor exposed new handler with the checks, that we would use in front of push handler? For example: ``` func (d *Distributor) CheckLimitsHandler(next http.Handler) http.Handler { return http.HandlerFunc(func(w...
> But now I introduced another problem - `Push` and `PushWithCleanup` have different semantics - one checks some limits, the other doesn't. I tried explaining that in the godoc. Do...