supabase-cache-helpers icon indicating copy to clipboard operation
supabase-cache-helpers copied to clipboard

Strip primary keys from the update payload

Open lauri865 opened this issue 1 year ago • 6 comments

Fixes #374.

lauri865 avatar Feb 13 '24 15:02 lauri865

🦋 Changeset detected

Latest commit: 64ae41fd0e298d1aa67387a319f9b6e06306301c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@supabase-cache-helpers/postgrest-core Minor
@supabase-cache-helpers/postgrest-react-query Minor
@supabase-cache-helpers/postgrest-swr Minor
@supabase-cache-helpers/examples/react-query Patch
@supabase-cache-helpers/examples/swr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 13 '24 15:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
supabase-cache-helpers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 7:05pm
supabase-cache-helpers-swr-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 7:05pm

vercel[bot] avatar Feb 13 '24 15:02 vercel[bot]

Someone is attempting to deploy a commit to a Personal Account owned by @psteinroe on Vercel.

@psteinroe first needs to authorize it.

vercel[bot] avatar Feb 13 '24 15:02 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4ffc4c8) 97.29% compared to head (64ae41f) 91.79%. Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   97.29%   91.79%   -5.51%     
==========================================
  Files         145       48      -97     
  Lines        2111      634    -1477     
  Branches      520      138     -382     
==========================================
- Hits         2054      582    -1472     
+ Misses         57       45      -12     
- Partials        0        7       +7     
Flag Coverage Δ
postgrest-core 91.79% <ø> (-6.57%) :arrow_down:
postgrest-react-query 91.79% <ø> (-5.25%) :arrow_down:
postgrest-swr 91.79% <ø> (-1.89%) :arrow_down:
storage-core 91.79% <ø> (-8.21%) :arrow_down:
storage-react-query 91.79% <ø> (-8.21%) :arrow_down:
storage-swr 91.79% <ø> (-8.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 16:02 codecov[bot]

@lauri865 can you write a changes?

psteinroe avatar Feb 13 '24 17:02 psteinroe

Added changest @psteinroe.

lauri865 avatar Feb 13 '24 19:02 lauri865

@psteinroe this seems like a bug worth fixing, did you close it because of a lack of response from @lauri865? I might have time to continue working on this if you're still interested in a fix (I've just ran into it on my first attempt to use supabase-cache-helpers).

elyobo avatar Aug 27 '24 15:08 elyobo

@elyobo yes, if you have the time I would appreciate this getting fixed very much 🙏🏼

psteinroe avatar Aug 27 '24 17:08 psteinroe

Happy to take a poke at it, but it seems like tests are failing even before running any changes; after installing with pnpm i in the current main branch I have test failures immediately. I may have missed some setup steps (I haven't worked with a turborepo repo before - some minimal getting started for contributors docs might be useful).

Edit: looking through the ci GHA workflow to figure out how to get tests working.

Edit: going through all the steps (build packages, run supabase, run tests with concurrency 1) generally works, although there are some intermittent failures. Should be enough to get things working.

elyobo avatar Aug 27 '24 23:08 elyobo