Patrick Stadler
Patrick Stadler
Contributions are welcome 👍🏻
I'm not sure whether this would make it more complicated.
That would make more sense, PRs welcome.
Functions can’t contain dashes. Need to implement something around `get_alias` I suppose.
Yes, please submit a pull request!
About `connect()`: Let's create a function which takes a single parameter. Optionally it could handle/transform the params we're using right now for compatibility reasons.
:+1: I had the exact same code stashed in my local repo a couple of weeks ago (including support for the argument order of the previous version) ... gonna push...
One more thing: ``` javascript Candy.Core.connect({ attach: { jid: '[email protected]', sid: '56da96be5419c52cbcf95594f129d537', rid: 1337 } }); ``` Yes or no?
`Candy.connect();` would make much more sense indeed.
Same here, I don't know if attach makes sense, but I'd not like it to be mixed (jid on the level above). Maybe we simply provide `Candy.attach(jid, sid, rid);` and...