did icon indicating copy to clipboard operation
did copied to clipboard

Fix issue with wrong `until` in GitHub search

Open Felixoid opened this issue 1 year ago • 4 comments

It fixes #362.

A decoupled part from #363

Felixoid avatar Oct 09 '24 07:10 Felixoid

Thanks for fixing this! Would you mind extending the /tests/github/issues and /tests/github/pulls tests with a simple test case demonstrating that the dates now work as expected?

psss avatar Oct 09 '24 07:10 psss

The PRs and issues appearing when running tests against the master:

https://github.com/teemtee/tmt/pull/1645, https://github.com/teemtee/tmt/pull/1644, https://github.com/teemtee/tmt/issues/1648, https://github.com/teemtee/tmt/issues/1650

Felixoid avatar Oct 09 '24 17:10 Felixoid

It was previously inconsistent with using somewhere defined local variables and somewhere not. Fixed it

Felixoid avatar Oct 10 '24 03:10 Felixoid

This PR is ready to review and merge. Since it touches the same code, I'll use it as a base for https://github.com/psss/did/pull/363.

Felixoid avatar Oct 18 '24 14:10 Felixoid

Dear @psss, I'd like to have it merged before the https://github.com/psss/did/pull/363. That PR uses the changed until and touches the code close to the same as here. Do you have time for a quick review?

Felixoid avatar Nov 08 '24 21:11 Felixoid

Hey-hey, happy new year!

A kind ping?

Felixoid avatar Jan 17 '25 15:01 Felixoid

Can you please rebase?

sandrobonazzola avatar May 19 '25 14:05 sandrobonazzola

It looks like it is still working, and all tests have passed.

Felixoid avatar May 19 '25 17:05 Felixoid

I see. I have not installed tenacity, so my isort considered it a local package.

Didn't know the codebase applied autopep8. Good to have an automated check for it.

I prefer black, but anything automated is perfect!

Felixoid avatar May 21 '25 09:05 Felixoid

Good to go?

Felixoid avatar Jun 01 '25 16:06 Felixoid

Thanks for improving this, @Felixoid! I just ran into a small regression caused by the change. Should be fixed by #405.

psss avatar Jun 03 '25 20:06 psss