Paulo Pinto

Results 56 comments of Paulo Pinto

The problem I see with this is that the state of the room can change (e.g. `history_visibility` can become non-world-readable) after it has been configured.

This is a Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1545573 Whenever the iframe gains focus, Firefox returns the parent's `` as `document.activeElement`, when it should be ``. This makes [this condition](https://github.com/WordPress/gutenberg/blob/trunk/packages/compose/src/hooks/use-focusable-iframe/index.ts#L29) evaluate as `false`,...

Thanks for looking into this proposal @bwindels! Agree, we would be making the changes behind a feature flag, which would allows us to spread the implementation across multiple PRs, and...

> list things of things that would need their updates passed over the message channel between the worker and the page @bwindels Is the opposite scenario also needed, i.e. passing...

Relying on sync to propagate the changes makes sense, server roundtrip should be fine indeed.

~I've added a couple of sections to the doc ([Worker lifetime and Gracefully closing sessions](https://github.com/vector-im/hydrogen-web/blob/6db66e8e50261ffc7832974aa3f517485d68d8f6/doc/implementation%20planning/sync-in-worker.md#worker-lifetime)) that address the discussions above about service worker vs shared worker, and other topics.~ ~In...

~I just realised that there are some things that aren't really clear in the [Worker lifetime and Gracefully closing sessions](https://github.com/vector-im/hydrogen-web/blob/6db66e8e50261ffc7832974aa3f517485d68d8f6/doc/implementation%20planning/sync-in-worker.md#worker-lifetime) so I'm giving it another pass. Will update here once...

@bwindels I've clarified the service worker vs shared worker topic in [the doc](https://github.com/vector-im/hydrogen-web/blob/ea19cf278842cfc870af08ae9d756e0135753867/doc/implementation%20planning/sync-in-worker.md#offload-sync-to-worker). In short, there's one `SharedWorker` per session: ```typescript const sessionId = "foo"; const worker = new SharedWorker(new...

Related: https://github.com/vector-im/hydrogen-web/issues/719

(There's a test repo that shows the issue at: https://github.com/psrpinto/playground-ts-test) While some of the typescript issues have indeed been fixed (e.g. `StartPlaygroundOptions` now has correct types), the `PlaygroundClient` type still...