Sebastian Gniazdowski comments

Results 153 comments of


                                            Sebastian Gniazdowski

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

@vladdoster come on, could the PR be merged quicker?

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

I've found a bug – CMake var should use `;` not `:` to separate dirs. Could the PR be merged?

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

@vladdoster See documentation of `CMAKE_PREFIX_PATH`: https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.html#variable:CMAKE_PREFIX_PATH It is perfect for what is needed to make `$ZPFSX` more discoverable.

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

OK, thanks for pointing where to look for info, I've made the commit message pass linter.

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

Ping?

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

@vladdoster the problem is that the unit tests are failing randomly and that I cannot use docker on my PCLInuxOS to generate documentation. You've once wrote that the documentation isn't...

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

@vladdoster: It buggs me that one still cannot compile with deps from `$ZPFX`. The unit test failures are accident, not related to the changes. So after generating zshelldoc docs one...

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

@vladdoster: I've found one other bug (`:` instead of `;`) and fixed it. The code is now without any errors, could it be merged? It opens `$ZPFX` installed libs to...

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

What about this PR? It is important.

[maint]: append "${ZPFX}/lib/pkg-config" to "${PKG_CONFIG_PATH}"

ping :) The unit test failure is some random one: ``` __zunit_tmp_test_function:17: exec format error: /Users/runner/work/zinit/zinit/tests/_support/tmp.TlWR1eUBGc/polaris/bin/git-mkver ```