Phips Peter

Results 60 comments of Phips Peter

I added this to my Jest configuration in `package.json` which seemed to help. ```json "jest": { "collectCoverage": true, "transform": { "^.+\\.(t|j)sx?$": [ "@swc/jest", { "sourceMaps": true } ] } }...

Primarily trying to reduce dependencies. If I'm using the Simplex Noise library, I'd like to avoid having to install the alea library if possible and have multiple version of the...

I agree with the naming convention distinction here. I'm happy with either solution as well, I just would rather not have two copies of Alea around. The advantage of dependency...

Will sign the CLA. This is a version of https://github.com/google/closure-stylesheets/pull/79 with a test for the default value and the required behavior. There are no tests that I could find easily...

@iflan Is there a way to build and run this jar locally? Running `mvn package` does not work.

Agreed. Running that jar however does not have a main attribute in the manifest file. What process is used to build the releases?

I'd like this as well, see https://github.com/google/closure-stylesheets/issues/89, is there anyway that I can help to finish this work?

I will likely create a fork for Asana and do the work necessary there. I just want to make sure that this will get merged if done. Thanks for the...

Another example would be the Cross Origin Response Header ``` Access-Control-Allow-Origin: * ```