Ruben Amendoeira comments

Results 59 comments of


                                            Ruben Amendoeira

Add "info message" and link to our discord on the "Name Changes" page

Added in the new beta website https://beta.wiseoldman.net/ I'll consider it done as it'll eventually be live in production. Closing.

Using enter, arrow & escape keys on search field

Added in the new beta website https://beta.wiseoldman.net/ I'll consider it done as it'll eventually be live in production. Closing.

New endpoint for split bossing and skilling data

This is really old, but since v2 of the API, skills and bosses are now separate. https://docs.wiseoldman.net/players-api/player-endpoints#get-player-details

[app] Prevent custom periods before 2013

This is very nice, the "invalid state" looks great, could you apply the same logic to the end date?

[app] Prevent custom periods before 2013

> I also wasn't sure if there were any contribution guides for labels and generalized styling choices. I looked around but was able to find anything. We don't have any...

[app] Prevent custom periods before 2013

Sorry for the delay on the review, a bit busy IRL atm. I do think you have overcomplicated this solution a bit. 1) The invalid "states" don't need to be...

[app] Prevent custom periods before 2013

Closing in favour of https://github.com/wise-old-man/wise-old-man/pull/1507

Async `generateMetadata` cause infinite loading in dynamic route after update to 14.1

This is a pretty serious issue, I believe this has caused my "Function execution" usage on Vercel to go up considerably (200-300%). This is really troublesome as it'll definitely cause...

Integers greater than 32 bits on multiple endpoints cause 500 error

This is an issue once again, as the routers have changed recently (possible due to zod's coerce function?), check `groups.router.ts`

Set Default Value for 'startDate' to January 1, 2013.

One last thing, could you also do that for endDateTime? It could also be incorrectly set to 1