Simon Bennetts

Results 614 comments of Simon Bennetts

I think theres zero chance of us changing the ZAP desktop to connect to a remote instance of ZAP. I like the idea, but it would be way too much...

Heres a class which create a dynamic menu list: https://github.com/zaproxy/zaproxy/blob/main/zap/src/main/java/org/zaproxy/zap/extension/alert/PopupMenuShowAlerts.java - does that help?

@jini0x we typically only re-review PRs when the author says they are ready to be checked again - I'm assuming thats the case here? :) I'll look at them asap...

> Not necessarily for this PR but in order to address #7167 could we add this menu to the start dialog? I'd much rather this was in a separate PR...

The previous version worked fine for me too...

@caladanjc where was Firefox installed? We _could_ potentially check this location on Windows as a special case...

I'm always in favour for improving the docs :) The existing help is https://www.zaproxy.org/docs/desktop/addons/selenium/options/ How do you think we could improve it?

I've just tried to upload an extension with a v2 manifest to the Chrome store but get this error: "You can no longer publish new Manifest V2 extensions. Try converting...

Try changing just the traditional plus report to include the otherinfo per instance. Then check it works with 2 alerts of the same type as above

Please! Dont forget to update the unit tests and the changelog. If the unit tests work without change then you'll need to add a new one to test this change.