Simon Bennetts

Results 625 comments of Simon Bennetts

Worth including links to James' research? (I think so;)

Thanks for taking this on! Have you checked that the rest of the code (including the UI) copes with env vars? I know in some cases we were checking that...

@rethab from the build failure logs ` Run './gradlew :addOns:automation:spotlessApply' to fix these violations.`

> > Thanks for the hints so far @psiinon & @thc202 . > > I guess this turns out to be not quite as easy as I thought/hoped, but I'm...

I think the best option is to leave the env vars in the data for as long as possible, so basically just applying them when they are applied to ZAP....

For info I havnt been able to reproduce this, so it could be a system dependant timing issue :/

This pull request **introduces 5 alerts** when merging bcde54ea6bf9d8b0c016deb780e33f754862270e into 3393ec0f9cbb86d6f88086b563cdae6758ba555e - [view on LGTM.com](https://lgtm.com/projects/g/zaproxy/zap-hud/rev/pr-92403b48d5c7dc742bd40085cac927bc5ff9070c) **new alerts:** * 3 for Unused variable, import, function or class * 2 for Missing...

Thanks @jaywon :) I'll have a good look through your proposal and give a more detailed response, but I'll give an immediate response now. ZAP has a plugin architecture. The...

@nothingismagick when the HUD communicates with ZAP it uses URLs that have a random component. These are the 'callback' URLs that ZAP supports for faking on domain content. They only...