aad-sso-wordpress
aad-sso-wordpress copied to clipboard
Groups picker/search in settings page
Rather than using the object IDs, if the current user is signed in via AAD, the groups field should allow for searching.
Check out this commit.. This changes the aad group inputs to select dropdowns if the tenant domain is saved: https://github.com/WebDevStudios/aad-sso-wordpress/commit/0a7e860c5c50b68c32c3cae5460edcf4f703e38e
I get the sense that org_domain_hint and the new tenent_domain are for the same purpose. Can you verify? if so, I'll merge the two and try to make the settings/documentation more clear about what the org_domain_hint field does.
I wonder if we should automatically populate (save the setting for) the org_domain_hint/tenent_domain settings after a user authenticates?
The groups input drop-down will only work for directories with a small number of groups. I left some notes in the relevant commits.
I really don't think tenant_domain
should exist at all. It should be taken out of the JWT token of the authenticated user. This ensures that:
- We are setting ourselves up to support multiple directories in the future.
- We only attempt to call AAD if there actually is a user that was authenticated with AAD (and thus, has an access token valid for Graph API).
And no, ord_id_domain_hint
is used for something else entirely.
I'm planning to take a look at this after i get the basic UI stuff sorted out.
I've started working on this.