psibre

Results 116 comments of psibre

The reason this bug was missed in the plugin's functional tests is that we don't actually override or add any custom entries to the generated config in the tests. But...

Upon closer inspection, it's not so much the custom entries that are the trigger for this bug going unnoticed, but the fact that the test that covers this was *disabled*...

This is turning in to quite an endeavor... I think we need to do another MR to follow up #129 and ensure that all tests are active and passing. Several...

## Example CI failures: - https://github.com/marytts/gradle-marytts-voicebuilding-plugin/runs/3059750690?check_suite_focus=true#step:8:233 - https://github.com/marytts/gradle-marytts-voicebuilding-plugin/runs/3059849775?check_suite_focus=true#step:8:230

The stacktrace above is thrown by ``` Gradle suite > Gradle test > de.dfki.mary.voicebuilding.VoiceLicenseExtensionTest > setup FAILED ``` The other one by ``` Gradle suite > Gradle test > de.dfki.mary.voicebuilding.VoiceExtensionTest...

Another one in https://github.com/marytts/gradle-marytts-voicebuilding-plugin/runs/3059997671?check_suite_focus=true#step:8:233: ``` Gradle suite > Gradle test > de.dfki.mary.voicebuilding.VoiceExtensionTest > setup FAILED org.gradle.api.GradleException: Could not inject synthetic classes. at org.gradle.initialization.DefaultLegacyTypesSupport.injectEmptyInterfacesIntoClassLoader(DefaultLegacyTypesSupport.java:91) at org.gradle.testfixtures.internal.ProjectBuilderImpl.getGlobalServices(ProjectBuilderImpl.java:161) at org.gradle.testfixtures.internal.ProjectBuilderImpl.createProject(ProjectBuilderImpl.java:106) at org.gradle.testfixtures.ProjectBuilder.build(ProjectBuilder.java:120) at...

Hummm. IIRC the idea was to *not* leak the Groovy dependency into the runtime classpath. If there is any requirement for Groovy at runtime, the voice should declare its own...

@seblemaguer Is this a problem with all voices, or just specific ones? Can you point me to an example?

The component plugin does generate Groovy code for the Config class, which is of course compiled by Groovy at build time, but that should not require Groovy at runtime. (Unlike,...

To build a voice, you should need neither the [marytts](https://github.com/marytts/marytts) nor the [voicebuilding plugin](https://github.com/marytts/gradle-marytts-voicebuilding-plugin) source code. You simply need a new Gradle project, which *applies* the voicebuilding plugin (retrieving it...