justl.el icon indicating copy to clipboard operation
justl.el copied to clipboard

Published 20 hours ago • verified publisher icon psibi

Only justfile filename is recognized

Open bram85 opened this issue 3 years ago • 8 comments

just detects a justfile without regarding the case (so also accepts Justfile, JUSTFILE, etc.) and even .justfile if you want to hide it.

justl only recognizes 'justfile', so it would be nice if both tools perform the same lookup mechanism.

bram85 avatar Mar 09 '22 18:03 bram85

Yeah, I agree this is a issue.

and even .justfile

I think this mode supports .justfile fine (Ref: https://github.com/psibi/justl.el/blob/73cb3a8f519dd555f73b981ac9c803b7489ce25b/justl.el#L189 ) That doesn't work for you ?

psibi avatar Mar 10 '22 03:03 psibi

Yes, .justfile does work for me.

I wrote the issue with the 'just' README on one side and only seeing the hardcoded 'justfile' on the other side, assuming only 'justfile' is supported.

Then all is left is the case insensitive matching.

bram85 avatar Mar 10 '22 05:03 bram85

Cool, thanks for the confirmation. :-)

psibi avatar Mar 10 '22 06:03 psibi

@bram85 Can you give this a try: https://github.com/psibi/justl.el/pull/14 ?

psibi avatar Mar 10 '22 17:03 psibi

Yes seems to work ok, thank you.

bram85 avatar Mar 10 '22 17:03 bram85

Cool. Fixed via https://github.com/psibi/justl.el/pull/14

psibi avatar Mar 11 '22 03:03 psibi

Is the support for .justfile drop? The current code seems to find justfile only.

https://github.com/psibi/justl.el/blob/476bf9c4fc3d753589f1cf2c13dc4e1e14aaba7e/justl.el#L156

failable avatar Feb 15 '24 02:02 failable

@liebkne Don't think that was intentional, PRs welcome.

psibi avatar Feb 17 '24 03:02 psibi

Fixed via https://github.com/psibi/justl.el/pull/63

psibi avatar Nov 15 '24 07:11 psibi