psi4 icon indicating copy to clipboard operation
psi4 copied to clipboard

maybe missing "}"

Open wszs opened this issue 1 year ago • 3 comments

hi friends,did you change the code recently? libscf_solver/hf.cc:772:22: error: qualified-id in declaration before ‘(’ token 772 | void HF::compute_fcpi() { | ^

i think that cause of missing "}" after line 770 in this file, it is right?

wszs avatar Jun 20 '24 01:06 wszs

I'm not seeing any change in compute_fcpi() in 6 years -- https://github.com/psi4/psi4/blame/master/psi4/src/psi4/libscf_solver/hf.cc#L772-L801 . I also did a fresh clone and compile of master earlier today, and it was fine, so I'm not sure what circumstances could lead to your error. If you're rebuilding psi4 after a long interval, I'd suggest a new objdir.

loriab avatar Jun 20 '24 01:06 loriab

I'm not seeing any change in in 6 years -- https://github.com/psi4/psi4/blame/master/psi4/src/psi4/libscf_solver/hf.cc#L772-L801 . I also did a fresh clone and compile of master earlier today, and it was fine, so I'm not sure what circumstances could lead to your error. If you're rebuilding psi4 after a long interval, I'd suggest a new objdir.compute_fcpi()

maybe because i enable brianqc? my compile being corrected after I add "}" btw , my link is https://github.com/psi4/psi4/tree/master/psi4/src/psi4/libscf_solver

wszs avatar Jun 20 '24 02:06 wszs

Aha, that makes perfect sense -- none of the Psi4 developers have access to BrianQC anymore. Lmk if the fix in #3186 isn't what you were suggesting.

loriab avatar Jun 20 '24 02:06 loriab

closed by #3186

loriab avatar Jul 24 '24 18:07 loriab