Psi+ XMPP client list logo/icon has been removed from source
Dear @psi-im team, @psi-plus team, @Ri0n, @Vitozz, @tehnick,
Psi+ logos/icons have been removed from source, Psi+ XMPP clients are now showed like Psi XMPP client into the Psi+ XMPP clients.
Comments done by @tehnick, official team member, about Psi IM and Psi+:
- https://github.com/psi-im/psi/issues/450#issuecomment-482160965
- https://github.com/psi-im/psi/issues/403#issuecomment-469018316
- https://github.com/psi-im/psi/blob/master/README.md#development
Thanks in advance.
Linked to:
- https://github.com/psi-im/psi/pull/892
i also believe that removing psi+ | psi-plus icons is wrong.
- i understand the try to make the codebase more simple, but removing a txt line from
client_icons.txtand delete an.png, i dont think it servers the above. - This change, while removes the ability to distinguish between a
psiandpsi-plusbuild for people that wish to, it adds absolute nothing. - as said before, icons do matter in guis. That was the main reason for windows os to be what is today. Icons is the main way users react with an app, no matter if they know it or not, the eye, the vision decides faster than logic.
- it's quiet usefull in a muc room to can tell what client, or what client version another user uses, without to have to do complicate things like service discovery. That help users to design the content of their messages better, and helps communication.
- it would be nice for a user or a developer who likes to run at the same time two different versions of
psi, like to test webkit/webengine builds, to easily can say from theiconwhich is what in the system tray. The same apply for the gui notifications. - icons are not a details. they carry info
- icons important or not, can have an important use and improrve user experience
- so,
-
- personally i think undo the commits rellated with the psiplus icon, would be ok.
-
- use a logic to
tiedthe icon with the build, and not with the product. This will help, to not remove/change nothing but the deletions atclient_icons.txt,iconssets.qrc.inandicondef.xml. icons related code is still there and works !
- use a logic to
thank you.
~ https://github.com/psi-im/psi/pull/892
@stokito fyi
it's quiet usefull in a muc room to can tell what client, or what client version another user uses, without to have to do complicate things like service discovery.
If you, for some reason is interested in the client name then hower a cursor and see it in a tooltip. But why would you interested in this? It was discussed in different places that the client should be hidden to avoid fingerprinting.
Once new Psi version released and become stable people won't need to use the dev/night build of the + and you won't see it anyway.
That help users to design the content of their messages better, and helps communication.
Let's better focus on interoperability so that you won't need to change anything in a message.
This is classical example bike-shedding from your and my side: I might not make the change, I just learning the codebase and started from a simplest possible tasks. Cleanup the decades old code is a good thing to do before adding new features.
Please, don't get it too emotional, instead try to contribute when you can. For example the #712 makes sense and not so difficult to implement even without the C++ knowledge.
Psi+ icon must always exist.
People will always generate Psi or Psi+ to have a Psi version and/or Psi+ version. A Psi and Psi+ launched at the same time.
Psi data:
- C:\Users\USERNAME\AppData\Roaming\Psi
Psi+ data:
- C:\Users\USERNAME\AppData\Roaming\Psi+
Of course, in more to select a profile in the client too.