psi-im
Add more client icons
Closes: #515 Closes: #517 Closes: #518 Closes: #519 Closes: #519 Closes: #521 Closes: #523 Closes: #524 Closes: #525 Closes: #606 Closes: #732
Additionally I added Tigase icons for all their clients: Stork (tested), Biggle (not tested), Siskin (not tested). Also for some reason in a MUC the Tigease may show a client a Multi User Chat.
It also would be nice to see bridges (e.g. Matrix to XMPP) and I added a few known bridges clients.
does it still follow the idea of not adding extremely rare or already dead client icons?
Checked in public chats. The Blabber is not that rare while it's abandoned. Others are rare - Monal - once, Qicksy two times, Jitsi never. But we don't know what happens in non public or company internal chats.
You didn't closed the this tasks so I just added the icons. This icons are less that 1Kb so not a big problem to have them even if switch to a bigger size.
Guys do not forget that each added icon to default iconset should be added to other iconsets according to iconset style of course. Otherwise if somebody will change iconset there will be no icons for new clients
@stokito: Can you re-add removed Psi+ icon at the same time, all people will be happy.
Linked to:
- https://github.com/psi-im/psi/issues/907
- https://github.com/psi-im/psi/pull/892
maybe we should make a full-blown plugin of it. move icons to the plugin and disable the plugin by default.
@Ri0n: Why another plugin again?
Icons in base code is good...
Note: Psi+ icon needs to be added again (it has been removed).
No to the:
Can you re-add removed Psi+
The Gajim has client icons as a plugin but not sure if it works. Even if you decide to make it as a plugin it's the lowest priority thing to do.
@Neustradamus just because I don't like the fact this thing may bloat psi endlessly. I wanted to keep a very minimal set of client icons in psi, letting to extend it with an external icon pack.
External plugin / icon pack has other benefits. controlled icon resolution, a sort of independence on other client. only one place to change, own independent releases.
So essentially this PR doesn't make much sense to me. From what I understood above adding blabber would be enough.
Even so I usually keep client icons enabled. this lets me see some stats.
The PR increases the size icons folder size from 136K to 184K, noticeable but yet not critical. It also contains a minimization of the PNG files, I'll extract the change to a separate PR. The problem with a separation is that anyway a user will install a plugins package with all of them so there won't be a real space saving.
I had a plan to load plugins from the internet. So this could save some space.
@Ri0n: For the moment, it can be added (Psi+ icon included), and after you can create a new plugin for it.
does it still follow the idea of not adding extremely rare or already dead client icons?
i think psi+ icon, blindly follow that idea. it's neither rare nor dead ! 😛
