Patrick Shriwise

Results 172 comments of Patrick Shriwise

Welp, this let me down the wonderful rabbit hole of cell instances and lattice offsets, uncovering a few different issues along the way. Thanks for your patience on this issue...

I agree this process could be more transparent. I'm you had to do so much digging to get it sorted out @bam241! I agree that at a minimum we should...

Also, it'd probably be good for us to figure out why different versions are an issue if possible.

@gridley We should definitely keep large models in mind for cell/material attributes 👍🏻 I'll keep that in mind should I find some time to submit a PR for this soon.

My test implementation of this is here for reference: https://github.com/pshriwise/openmc/tree/write-tally-specs

Thanks for noting this @teade. @eepeterson noticed some odd interactivity between these two forms of variance reduction. I'll break the survival biasing method into two processes: - Reduced particle weight...

I think as a short-term measure a warning about this would be useful, no? I'm primarily for that b/c survival biasing isn't enabled by default. Hrmmm I like it @teade,...

Hi @teade. Good points! Thanks for raising this. This _is_ pretty confusing and the default value we settled on for the max number of history splits is rather low. I...

Yes this is still available @vanessalulla. Thank you for taking it on!

Just noting this comment on the geometry description this morning: > Geometry Description: Water-filled sphere centerd at the origin surrounded by a vacuum region. @Itay-max, is this based on the...