requests
requests copied to clipboard
Make the SSL version more human-readable
When executing python -m requests.help, the previous format looked like:
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": "40.0.2"
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.6.8"
},
"platform": {
"release": "3.10.0-1160.119.1.el7.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30100000",
"version": "23.2.0"
},
"requests": {
"version": "2.27.1"
},
"system_ssl": {
"version": "100020bf"
},
"urllib3": {
"version": "1.26.19"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
The current format looks like:
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": "40.0.2"
},
"idna": {
"version": "3.7"
},
"implementation": {
"name": "CPython",
"version": "3.6.8"
},
"platform": {
"release": "3.10.0-1160.119.1.el7.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "OpenSSL 3.1.0 14 Mar 2023",
"version": "23.2.0"
},
"requests": {
"version": "2.27.1"
},
"system_ssl": {
"version": "OpenSSL 1.0.2k-fips 26 Jan 2017"
},
"urllib3": {
"version": "1.26.19"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
I'm not opposed to adding a human readable representation but the existing representation should be reserved with a new key added for the human readable representation
I'm not opposed to adding a human readable representation but the existing representation should be reserved with a new key added for the human readable representation
You're right — backward compatibility should be considered. The changes have been resubmitted.
@sigmavirus24