requests icon indicating copy to clipboard operation
requests copied to clipboard

Documentation: Session docstring for verify attribute should note that it supports a string value.

Open muscovite opened this issue 1 year ago • 2 comments

Session docstring for verify attribute should note that it supports a string value.

Actual Result

Currently, the Session docstring notes that its verify attribute only supports a bool.

However, session.request supports a string for its verify arg: https://github.com/psf/requests/blob/main/src/requests/sessions.py#L550

and when a verify arg isn't passed to session.request, then session.verify is used instead:

https://github.com/psf/requests/blob/main/src/requests/sessions.py#L776 https://github.com/psf/requests/blob/main/src/requests/sessions.py#L70

Reproduction Steps

N/A

System Information

N/A

muscovite avatar Dec 16 '24 22:12 muscovite

I've submitted a PR (#6865) to address this issue. Please let me know if there are additional changes required. Thank you!

M0d3v1 avatar Jan 01 '25 16:01 M0d3v1

hey i want to work on this issue, could you please assign me this issue

rahul-vyas-dev avatar Jan 12 '25 13:01 rahul-vyas-dev