requests icon indicating copy to clipboard operation
requests copied to clipboard

Start testing on 3.13 beta

Open nateprewitt opened this issue 1 year ago • 4 comments

It looks like we're currently blocked on wheels for a few testing dependencies so this isn't mergable currently but we'll use this PR to monitor upstream support from other projects. Once those blockers are moved, we can merge this into our CI to prepare for the upcoming release candidates.

Currently it looks like flsgger and greenlet are having issues from httpbin. I think we have an open proposal/request to make flsgger optional which seems fine. greenlet currently has a proposed patch from Victor Stinner so I would assume that's resolved sooner than later.

nateprewitt avatar May 23 '24 19:05 nateprewitt

Looks like we're still blocked on https://github.com/python-greenlet/greenlet/issues/392. Victor Stinner's patch which appears to fix the issue has been stalled for a couple months. We'll continue to keep an eye on that as we get closer to 3.13 release on October 1st, 2024.

nateprewitt avatar Aug 02 '24 18:08 nateprewitt

@nateprewitt Is greenlet only needed for the gunicorn worker? Could we drop that as well in httpbin in favor of some other worker type? Or some other WSGI implementation?

sethmlarson avatar Aug 02 '24 20:08 sethmlarson

Yeah, we definitely have options in httpbin to resolve the issue. I was going to wait until we're close to 3.13 release before we started pursuing changes there. We honestly don't even need flasgger there, it was a very late add to the project before development stopped. I would bias towards us just moving that to an optional dependency.

nateprewitt avatar Aug 02 '24 21:08 nateprewitt

@nateprewitt greenlet is only needed as a dependency of gevent, it shouldn't be a direct dep https://github.com/psf/httpbin/pull/51

It's currently blocking pytest-httpbin 3.13 support: https://github.com/kevin1024/pytest-httpbin/pull/90

graingert avatar Aug 08 '24 08:08 graingert