requests
requests copied to clipboard
Fix broken links in docs
Hi,
I noticed a broken link to rfc2988 in the timeout section of the docs and thought I would fix it.
While doing that, I thought I would run the sphinx linkcheck
builder to check for other broken links and fix them.
There were a few, some where I've 'fixed'/updated the link are hopefully uncontroversial.
Some are more controversial - removing sections written by the original author of requests that now have dead links, removing talks with dead links to slides, removing people's now dead GitHub account links. I wasn't sure what the right thing to do here was, but I went with my intuition, and kept commits pretty discrete so I can drop/amend them if the maintainers want me to do something different. If some are controversial enough to slow down the PR, I can always pull out the uncontroversial ones into their own PR for faster merging.
@sigmavirus24 Thanks for your comments - I think this is ready to look at again whenever you have time. No rush from my side, I'm sure you're busy, just didn't want it to get stuck in process if you thought I was still working on it!
Thanks @Jamim for the review!
It looks like GitHub still wants an approval from a reviewer with write access - I'm guessing you don't have write access (just checking in case something has gone wrong with the process)?
I've just rebased against main so this is fresh and to give the GitHub checks another change to pass - looks like the build
checks for any python >3.7 are failing with this error:
ImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/werkzeug/http.py)
But the 3.7 ones pass, and this error also occurred in the checks for the latest commit to main, so this seems to be an unrelated wekzeug
dependency-related issue to me.
I'm guessing you don't have write access
That's true. I just wanted to support your contribution 😃
@EFord36 would you be willing to rebase/resolve the conflicts here?
@EFord36 would you be willing to rebase/resolve the conflicts here?
Hi,
I've done that now, thanks for the reminder!
Thank you!