requests icon indicating copy to clipboard operation
requests copied to clipboard

every chardet package maps to requests.packages.chardet.* package respectively

Open amkarn258 opened this issue 1 year ago • 3 comments

Added a fix for the issue mentioned here - https://github.com/psf/requests/issues/6223

Checked in the code, only one package of chardet was being mapped to requests.packages.chardet despite the for loop.

Have added the fix so each chardet package maps to it's corresponding requests.packages.chardet.* respectively.

amkarn258 avatar Oct 30 '23 19:10 amkarn258

Your PR as is will still have the same issue you reported and does not fix it. I've added a suggestion

sigmavirus24 avatar Oct 31 '23 16:10 sigmavirus24

Same checks are failing on the main branch - https://github.com/psf/requests/issues/6566

I think the issue is with werkzeug latest version which gets downloaded due to dependency with httpbin

amkarn258 avatar Nov 05 '23 07:11 amkarn258

Is there anything more required in this PR to be merged? Or is it on standby until the httpbin issue gets resolved @sigmavirus24

amkarn258 avatar Nov 13 '23 14:11 amkarn258

closing & reopening to trigger new build

sigmavirus24 avatar Feb 23 '24 00:02 sigmavirus24