requests icon indicating copy to clipboard operation
requests copied to clipboard

Published 20 hours ago • verified publisher icon psf

Add ipv6 support to should_bypass_proxies

Open derekhiggins opened this issue 4 years ago • 10 comments

Add support to should_bypass_proxies to support IPv6 ipaddresses and CIDRs in no_proxy. Includes adding IPv6 support to various other helper functions.

derekhiggins avatar Oct 08 '21 14:10 derekhiggins

Hi @nateprewitt @sethmlarson , is this something you'd consider merging ?

derekhiggins avatar Jan 09 '23 10:01 derekhiggins

I'm facing this same issue. @nateprewitt @sethmlarson Any update on your thoughts?

melewitz avatar Jan 11 '23 14:01 melewitz

Running into the same problem with this, it sure would be nice to have the ability to specify IPv6 CIDRs in no_proxy. What's holding this up?

novacain1 avatar Oct 11 '23 12:10 novacain1

@nateprewitt @sigmavirus24 @sethmlarson would you have a chance to look at this please, its been hanging around for over 2 years and still causing me problems.

derekhiggins avatar Nov 28 '23 12:11 derekhiggins

It'd be nice to have this implemented. Is there any way I can help?

frenzymadness avatar Dec 14 '23 14:12 frenzymadness

Hi @frenzymadness , if you can review or confirm that this works for your use case then that would be appreciated but ultimately this PR has been waiting on reviews from one of the maintainers I'm not sure how best to get it some traction besides pinging them on here.

derekhiggins avatar Dec 14 '23 16:12 derekhiggins

We are going to test this change internally to get some confidence.

frenzymadness avatar Jan 02 '24 12:01 frenzymadness

Derek tested the package in OpenShift 4.15 and the functionality proposed here works as expected. Is there any chance to merge this?

frenzymadness avatar Jan 04 '24 07:01 frenzymadness

During additional testing, my colleague raised an interesting question: Are ::/0 and 0.0.0.0/0 valid values for no_proxy? The current implementation for IPv4 does not allow masks to be lower than 1 and the new implementation for IPv6 does the same.

I see a use-case for ::/0 - let's say I have a proxy running on both protocols but I want it to be used only for IPv4 - then it might make sense to use NO_PROXY for all IPv6 addresses. What do you think?

frenzymadness avatar Jan 25 '24 11:01 frenzymadness